Skip to content

Translate tidb computing #3057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 63 commits into from
Jul 20, 2020
Merged

Translate tidb computing #3057

merged 63 commits into from
Jul 20, 2020

Conversation

@baurine
Copy link
Contributor

@baurine baurine commented Jun 28, 2020 •
edited by TomShawn
Loading

What is changed, added or deleted? (Required)

Translate the TiDB Computation chapter from Chinese to English.
This PR should be merged after #3094 for the TOC to be updated.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@CLAassistant
Copy link

CLAassistant commented Jun 28, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot requested a review from TomShawn June 28, 2020 13:45
@github-actions github-actions bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jun 28, 2020
@baurine
Copy link
Contributor Author

baurine commented Jun 28, 2020

@SunRunAway @yikeke PTAL, thanks!

@TomShawn TomShawn requested a review from SunRunAway June 28, 2020 13:52
@TomShawn TomShawn added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 28, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jun 30, 2020

@SunRunAway, @TomShawn, PTAL.

2 similar comments
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 2, 2020

@SunRunAway, @TomShawn, PTAL.

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 5, 2020

@SunRunAway, @TomShawn, PTAL.

@TomShawn TomShawn added the special-week PR from Document Special Week. label Jul 6, 2020
TomShawn
TomShawn reviewed Jul 6, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good translation! I'll review the rest part soon.

@TomShawn TomShawn added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels Jul 6, 2020
TomShawn
TomShawn reviewed Jul 7, 2020
View reviewed changes
TomShawn
TomShawn reviewed Jul 8, 2020
View reviewed changes
TomShawn
TomShawn reviewed Jul 8, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second round of review

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 10, 2020

@baurine, please update your pull request.

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 10, 2020

@TomShawn, @SunRunAway, PTAL.

@TomShawn
Copy link
Contributor

TomShawn commented Jul 13, 2020

LGTM
@SunRunAway PTAL

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 15, 2020

@TomShawn, @SunRunAway, PTAL.

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 15, 2020

@baurine, please update your pull request.

@baurine
Copy link
Contributor Author

baurine commented Jul 15, 2020

Err, seems I have no permission to push code, what should I continue to do for this PR?

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 17, 2020

@TomShawn, @SunRunAway, PTAL.

TomShawn
TomShawn reviewed Jul 17, 2020
View reviewed changes
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 19, 2020

@TomShawn, @SunRunAway, PTAL.

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 19, 2020

@baurine, please update your pull request.

SunRunAway
SunRunAway reviewed Jul 20, 2020
View reviewed changes
@TomShawn @SunRunAway
Update tidb-computing.md
3e6ef48 
Co-authored-by: Feng Liyuan <darktemplar.f@gmail.com>
SunRunAway
SunRunAway reviewed Jul 20, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 20, 2020

@SunRunAway,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

TomShawn
TomShawn approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2020
@TomShawn TomShawn merged commit 38620d3 into master Jul 20, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 20, 2020
@baurine @ti-srebot
cherry pick pingcap#3057 to release-4.0
01de77b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 20, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 20, 2020

cherry pick to release-4.0 in PR #3341

TomShawn added a commit that referenced this pull request Jul 20, 2020
@ti-srebot @baurine @TomShawn
Translate tidb computing (#3057) (#3341)
e470472 
* cherry pick #3057 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Apply suggestions from code review

Co-authored-by: Sparkle <1284531+baurine@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@baurine baurine deleted the translate-tidb-computing branch July 20, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

special-week PR from Document Special Week. status/LGT1 Indicates that a PR has LGTM 1. status/require-change Needs the author to address comments. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@baurine @CLAassistant @ti-srebot @TomShawn @SunRunAway