Skip to content

Update TiDB architecture #3094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jul 16, 2020
Merged

Update TiDB architecture #3094

merged 25 commits into from
Jul 16, 2020

Conversation

@uglyengineer
Copy link
Contributor

@uglyengineer uglyengineer commented Jun 30, 2020 •
edited by lilin90
Loading

What is changed, added or deleted? (Required)

Update content for architecture.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@CLAassistant
Copy link

CLAassistant commented Jun 30, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@uglyengineer
Copy link
Contributor Author

uglyengineer commented Jun 30, 2020

@SunRunAway @TomShawn PTAL, thanks!

@yikeke yikeke requested review from SunRunAway and lilin90 July 1, 2020 02:27
@yikeke yikeke added needs-cherry-pick-4.0 status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jul 1, 2020
lilin90
lilin90 reviewed Jul 2, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did a quick review of format.

@lilin90 lilin90 added size/medium Changes of a medium size. status/require-change Needs the author to address comments. labels Jul 2, 2020
uglyengineer and others added 3 commits July 4, 2020 01:40
@uglyengineer @lilin90
Update architecture.md
f6d2365 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@uglyengineer @lilin90
Update architecture.md
ac493c8 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@uglyengineer @lilin90
Update architecture.md
34d479e 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 4, 2020

@lilin90, @SunRunAway, PTAL.

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 5, 2020

@uglyengineer, please update your pull request.

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 6, 2020

@lilin90, @SunRunAway, PTAL.

@baurine baurine mentioned this pull request Jul 6, 2020
Merged
5 tasks
@lilin90
Copy link
Member

lilin90 commented Jul 7, 2020

@uglyengineer Please fix the image link which causes lint failure.

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 9, 2020

@lilin90, @SunRunAway, PTAL.

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 9, 2020

@uglyengineer, please update your pull request.

@uglyengineer uglyengineer requested a review from lilin90 July 11, 2020 10:17
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 13, 2020

@uglyengineer, please update your pull request.

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 13, 2020

@lilin90, @SunRunAway, PTAL.

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 15, 2020

@lilin90, @SunRunAway, PTAL.

@lilin90 lilin90 changed the title Update architecture.md Update TiDB architecture Jul 16, 2020
lilin90
lilin90 reviewed Jul 16, 2020
View reviewed changes
lilin90 and others added 12 commits July 16, 2020 17:06
@lilin90
Fix an anchor link to resolve lint failure
f9eada5
@lilin90
Merge branch 'master' into update-arch
ff30ee2
@uglyengineer @lilin90
Update architecture.md
486e170 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@uglyengineer @lilin90
Update architecture.md
e1cee63 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@uglyengineer @lilin90
Update architecture.md
a122859 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@uglyengineer @lilin90
Update architecture.md
1fc690e 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@uglyengineer @lilin90
Update architecture.md
8167e7c 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@uglyengineer @lilin90
Update architecture.md
695be2f 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@uglyengineer @lilin90
Update architecture.md
54b279b 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@uglyengineer @lilin90
Update architecture.md
d20f10e 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@uglyengineer @lilin90
Update architecture.md
beb9d4b 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@uglyengineer @lilin90
Update architecture.md
4839fb2 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@uglyengineer uglyengineer requested a review from lilin90 July 16, 2020 09:11
lilin90
lilin90 reviewed Jul 16, 2020
View reviewed changes
lilin90
lilin90 approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 16, 2020
@lilin90 lilin90 merged commit 22425b6 into pingcap:master Jul 16, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 16, 2020
@uglyengineer @ti-srebot
cherry pick pingcap#3094 to release-4.0
4814882 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 16, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 16, 2020

cherry pick to release-4.0 in PR #3299

ti-srebot added a commit that referenced this pull request Jul 16, 2020
@ti-srebot
Update TiDB architecture (#3094) (#3299)
04ffe5a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ran-huang
ran-huang reviewed Jul 16, 2020
View reviewed changes
TOC.md
+ Reference
+ [Architecture](/architecture.md)
+ Cluster Architecture
+ [Overview](/architecture.md)
Copy link
Contributor

@ran-huang ran-huang Jul 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lilin90 @uglyengineer The corresponding Chinese file is tidb-architecture.md. Different file names might bring inconvenience to later maintenance. Is this by design?

Copy link
Contributor

@yikeke yikeke Jul 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest renaming it to tidb-architecture.md to align the Chinese doc. @lilin90 @uglyengineer

Can you do it in your PR #3300? @ran-huang

Copy link
Contributor

@ran-huang ran-huang Jul 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Updated.

@ran-huang ran-huang mentioned this pull request Jul 16, 2020
Merged
5 tasks
This was referenced Jul 16, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilin90 lilin90 lilin90 approved these changes

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

+2 more reviewers

@yikeke yikeke yikeke left review comments

@ran-huang ran-huang ran-huang left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/medium Changes of a medium size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. status/require-change Needs the author to address comments. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@uglyengineer @CLAassistant @ti-srebot @lilin90 @yikeke @ran-huang