Skip to content

Conversation

@ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Jul 16, 2020

Signed-off-by: Ran huangran@pingcap.com

What is changed, added or deleted? (Required)

CI fails because the Chinese file tidb-architecture.md is changed to architecture.md in English (#3094).
Will confirm with the author about the correct file name.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Signed-off-by: Ran <huangran@pingcap.com>
@ran-huang ran-huang requested a review from yikeke July 16, 2020 10:28
@ran-huang ran-huang added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jul 16, 2020
yikeke
yikeke previously approved these changes Jul 16, 2020
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 16, 2020
@yikeke yikeke added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 16, 2020
ran-huang and others added 2 commits July 16, 2020 20:24
Signed-off-by: Ran <huangran@pingcap.com>
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Jul 16, 2020
@yikeke yikeke merged commit 19bf4a3 into pingcap:master Jul 16, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 16, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3304

ran-huang added a commit that referenced this pull request Jul 16, 2020
* cherry pick #3300 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update tidb-architecture.md

Co-authored-by: Ran <huangran@pingcap.com>
@ran-huang ran-huang deleted the update-quick-start-link branch July 30, 2020 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

require-LGT1 Indicates that the PR requires an LGTM. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants