Skip to content

perf-tuning: update statistics.md #3332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 20, 2020
Merged

perf-tuning: update statistics.md #3332

merged 6 commits into from
Jul 20, 2020

Conversation

@toutdesuite
Copy link
Contributor

@toutdesuite toutdesuite commented Jul 20, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

update statistics.md
在[索引的选择](/index-choose.md)章节中，提到了 TiDB 会使用统计信息来决定选择哪个索引。 has not been translated because index-choose.md does not exist in the docs repo.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@toutdesuite toutdesuite requested a review from TomShawn July 20, 2020 02:22
@toutdesuite toutdesuite marked this pull request as draft July 20, 2020 02:26
@toutdesuite toutdesuite requested a review from winoros July 20, 2020 02:51
@toutdesuite toutdesuite marked this pull request as ready for review July 20, 2020 02:51
@toutdesuite toutdesuite added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. requires-followup This PR requires a follow-up task after being merged. labels Jul 20, 2020
@yikeke yikeke requested review from ran-huang and removed request for TomShawn July 20, 2020 04:11
@yikeke yikeke mentioned this pull request Jul 20, 2020
Merged
5 tasks
ran-huang
ran-huang reviewed Jul 20, 2020
View reviewed changes
winoros
winoros reviewed Jul 20, 2020
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 20, 2020

@winoros,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2020
@toutdesuite toutdesuite added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 20, 2020

@toutdesuite Oops! This PR requires at least 2 LGTMs to merge. The current number of LGTM is 1.

@toutdesuite toutdesuite merged commit 6649859 into pingcap:master Jul 20, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 20, 2020
@toutdesuite @ti-srebot
cherry pick pingcap#3332 to release-4.0
b3f0474 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 20, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 20, 2020

cherry pick to release-4.0 in PR #3345

@toutdesuite toutdesuite deleted the statistics branch July 20, 2020 13:02
toutdesuite added a commit that referenced this pull request Jul 20, 2020
@ti-srebot @toutdesuite
cherry pick #3332 to release-4.0 (#3345)
fc2a888 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: toutdesuite <guizhiluo2014@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@winoros winoros winoros left review comments

+1 more reviewer

@ran-huang ran-huang ran-huang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

requires-followup This PR requires a follow-up task after being merged. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@toutdesuite @ti-srebot @winoros @ran-huang