Skip to content

Conversation

@ti-srebot
Copy link
Contributor

cherry-pick #3801 to release-4.0


What is changed, added or deleted? (Required)

I think it should be require x509

I tested this SQL create user 'u1'@'%' require 509; . The error result returned is as follows

MySQL [(none)]> create user 'u1'@'%'  require 509;
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your TiDB version for the right syntax to use line 1 column 33 near "509"

create user 'u1'@'%' require x509; is right .

MySQL [(none)]> create user 'u1'@'%'  require x509;
Query OK, 0 rows affected (0.02 sec)

PS : I just want to try and submit a PR .
😃

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 2, 2020
5 tasks
@ti-srebot ti-srebot added contribution This PR is from a community contributor. size/small Changes of a small size. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Sep 2, 2020
@ti-srebot ti-srebot requested review from lilin90 and lysu September 2, 2020 11:24
@ti-srebot ti-srebot self-assigned this Sep 2, 2020
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 2, 2020
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 2, 2020
@lilin90 lilin90 merged commit 41f32f4 into pingcap:release-4.0 Sep 2, 2020
@lilin90 lilin90 deleted the release-4.0-02e83f39131d branch September 2, 2020 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. size/small Changes of a small size. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants