Skip to content

fix: TiCDC new arch dashboard file is missing#895

Merged
ti-chi-bot[bot] merged 2 commits into
masterfrom
csuzhangxc/fix-cdc-newarch-missing
Sep 16, 2025
Merged

fix: TiCDC new arch dashboard file is missing#895
ti-chi-bot[bot] merged 2 commits into
masterfrom
csuzhangxc/fix-cdc-newarch-missing

Conversation

@csuzhangxc
Copy link
Copy Markdown
Member

@csuzhangxc csuzhangxc commented Sep 16, 2025 •
edited
Loading

Only setting in the following two places is not enough:

  • monitoring/monitoring.yaml

    Lines 22 to 23 in 71d0c7b

    - repo_name: "ticdc"
    monitor_path: "metrics/grafana"

  • monitoring/cmd/init.sh

    Lines 99 to 101 in 71d0c7b

    # TiCDC New Arch
    cp /tmp/ticdc_new_arch.json $GF_PROVISIONING_PATH/dashboards
    sed -i 's/Test-Cluster-TiCDC-New-Arch/'$TIDB_CLUSTER_NAME'-TiCDC/g' $GF_PROVISIONING_PATH/dashboards/ticdc_new_arch.json

@ti-chi-bot ti-chi-bot Bot added the size/XS label Sep 16, 2025
@wuhuizuo wuhuizuo closed this Sep 16, 2025
@wuhuizuo wuhuizuo reopened this Sep 16, 2025
@wuhuizuo
Copy link
Copy Markdown
Contributor

wuhuizuo commented Sep 16, 2025

/check-cla

@ti-chi-bot ti-chi-bot Bot removed the lgtm label Sep 16, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Sep 16, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-16 03:32:52.534930472 +0000 UTC m=+937039.094811979: ☑️ agreed by liubog2008.
  • 2025-09-16 04:10:27.967456908 +0000 UTC m=+939294.527338415: ✖️🔁 reset by csuzhangxc.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Sep 16, 2025

New changes are detected. LGTM label has been removed.

@csuzhangxc
Copy link
Copy Markdown
Member Author

csuzhangxc commented Sep 16, 2025

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Sep 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc, liubog2008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [csuzhangxc,liubog2008]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot merged commit 5881a86 into master Sep 16, 2025
2 checks passed
@ti-chi-bot ti-chi-bot Bot deleted the csuzhangxc/fix-cdc-newarch-missing branch September 16, 2025 04:18
@wlwilliamx
Copy link
Copy Markdown
Contributor

wlwilliamx commented Nov 10, 2025

/cherry-pick release-8.5

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Nov 10, 2025

@wlwilliamx: new pull request created to branch release-8.5: #922.

Details

In response to this:

/cherry-pick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 10, 2025
Merged
ti-chi-bot Bot pushed a commit that referenced this pull request Nov 10, 2025
@ti-chi-bot @csuzhangxc
fix: TiCDC new arch dashboard file is missing (#895) (#922)
d2be549 
* fix: TiCDC new arch dashboard file is missing

* trigger

---------

Co-authored-by: csuzhangxc <csuzhangxc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liubog2008 liubog2008 liubog2008 approved these changes

Assignees

No one assigned

Labels

approved lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@csuzhangxc @wuhuizuo @wlwilliamx @ti-chi-bot @liubog2008