Skip to content

fix: TiCDC new arch dashboard file is missing #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ti-chi-bot merged 2 commits into from
Sep 16, 2025
Merged

fix: TiCDC new arch dashboard file is missing #895

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d88a1e5
fix: TiCDC new arch dashboard file is missing
csuzhangxc Sep 16, 2025
c1056cc
trigger
csuzhangxc Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/operator/dashboards.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package operator

import (
"errors"
"fmt"
"strings"

Expand Down Expand Up @@ -38,6 +37,7 @@ var (
"tiflash_proxy_summary.json": "Test-Cluster-TiFlash-Proxy-Summary",
"ticdc.json": "Test-Cluster-TiCDC",
"TiCDC-Monitor-Summary.json": "Test-Cluster-TiCDC-Summary",
"ticdc_new_arch.json": "Test-Cluster-TiCDC-New-Arch",
"tikv-cdc.json": "Test-Cluster-TiKV-CDC",
"tiflash_proxy_details.json": "Test-Cluster-TiFlash-Proxy-Details",
"DM-Monitor-Standard.json": "Test-Cluster-DM-Standard",
Expand All @@ -49,7 +49,7 @@ var (
func WriteDashboard(dir string, body string, name string) error {
title, exist := dashboards[name]
if !exist {
return errors.New(fmt.Sprintf("%s dashboard is not found in operator", name))
return fmt.Errorf("%s dashboard is not found in operator", name)
}

common.WriteFile(dir, convertDashboardFileName(name), filterDashboard(body, name, title))
Expand Down