Skip to content

test: verify default timestamp test with pool fix - #5413

Closed
hongyunyan wants to merge 13 commits into
pingcap:masterfrom
hongyunyan:codex/verify-pr5335-with-pr5397
Closed

test: verify default timestamp test with pool fix#5413
hongyunyan wants to merge 13 commits into
pingcap:masterfrom
hongyunyan:codex/verify-pr5335-with-pr5397

Conversation

@hongyunyan

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: ref #5335, ref #5397

This is a CI-only validation PR. PR #5335 adds coverage for replicating DDL default current timestamp behavior, and PR #5397 fixes MySQL sink connection-pool ownership around DML and control database access. This PR combines both heads so GitHub CI can validate the new #5335 tests with the #5397 fix applied.

What is changed and how it works?

This branch is based on the latest head of #5335 and merges the latest head of #5397. It does not introduce additional implementation changes beyond those two PRs.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test: not run locally for this validation PR; this PR is opened to let GitHub CI run the combined change set.

Questions

Will it cause performance regression or break compatibility?

No. This is a validation PR that only combines #5335 and #5397 for CI.

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note

None.

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 16, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot

ti-chi-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@ti-chi-bot

ti-chi-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wk989898 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@hongyunyan, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 48 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d2a312e0-4201-4d67-afc1-7fd08835a903

📥 Commits

Reviewing files that changed from the base of the PR and between fc24e66 and a1f0a2f.

📒 Files selected for processing (8)
  • downstreamadapter/sink/mysql/sink.go
  • downstreamadapter/sink/mysql/sink_test.go
  • downstreamadapter/sink/pulsar/sink.go
  • pkg/applier/redo.go
  • pkg/applier/redo_test.go
  • pkg/sink/mysql/config.go
  • pkg/sink/mysql/config_test.go
  • tests/integration_tests/run_light_it_in_ci.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ti-chi-bot ti-chi-bot Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 16, 2026
@hongyunyan
hongyunyan marked this pull request as ready for review June 16, 2026 04:16
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2026
@hongyunyan

Copy link
Copy Markdown
Collaborator Author

/test pull-cdc-mysql-integration-light

@ti-chi-bot

ti-chi-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

@hongyunyan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-mysql-integration-light a1f0a2f link true /test pull-cdc-mysql-integration-light

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hongyunyan hongyunyan closed this Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/needs-linked-issue do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants