test: add test case in debezium protocol by wk989898 · Pull Request #5606 · pingcap/ticdc

wk989898 · 2026-07-09T08:08:17Z

What problem does this PR solve?

Issue Number: close #5605

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

Summary by CodeRabbit

Tests
- Updated database integration test data to cover an expanded table schema and additional insert/update scenarios.
- Added coverage for rows with a new text field, a newly added column, and a default-value insert.

Signed-off-by: wk989898 <nhsmwk@gmail.com>

coderabbitai · 2026-07-09T08:09:32Z

📝 Walkthrough

Walkthrough

Updated the tp_time table test fixture in data.sql: added a c_txt column with corresponding insert statement updates, appended an ALTER TABLE adding c_newcol, and added an extra empty-row insert to exercise null datetime value handling.

Changes

tp_time test data update

Layer / File(s)	Summary
Extend tp_time schema and DML `tests/integration_tests/debezium_basic/data/data.sql`	Added `c_txt` column to `tp_time`, updated inserts to supply `c_txt` values, appended `ALTER TABLE` adding `c_newcol`, and added an extra empty-row insert to test null datetime handling.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested labels: lgtm, approved

Suggested reviewers: asddongmen

Poem

A column named c_txt hops into view,
c_newcol follows, with nulls to chew,
One empty row, a debezium test,
This bunny nibbles bugs with zest! 🐰
Hop, commit, and test anew!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The template is present, but key sections like changes, tests, questions, and release note are left unfilled.	Fill in what changed, select and describe the tests run, answer the questions, and add a release note or 'None'.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The updated integration test data matches issue `#5605` by covering the nullable datetime column added via ALTER TABLE and the empty-row insert that triggered the encode failure.
Out of Scope Changes check	✅ Passed	The only touched file is the Debezium integration test fixture, which is directly aligned with the reported bug scenario.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title matches the main change: adding a Debezium protocol test case.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

gemini-code-assist

Code Review

This pull request updates the integration test data in tests/integration_tests/debezium_basic/data/data.sql by adding a new column c_txt to the tp_time table, updating existing insert statements, and appending an ALTER TABLE statement to add another column c_newcol. The review feedback suggests formatting improvements to maintain consistency, specifically using lowercase for default null and adding a missing space in one of the insert statements.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

gemini-code-assist · 2026-07-09T08:13:27Z

    c_timestamp timestamp null,
    c_time      time      null,
    c_year      year      null,
+    c_txt varchar(255) COLLATE utf8mb4_general_ci DEFAULT NULL,


To maintain consistency with the rest of the table definition (which uses lowercase null and lowercase SQL keywords), please use lowercase default null instead of uppercase DEFAULT NULL.

c_txt varchar(255) COLLATE utf8mb4_general_ci default null,

gemini-code-assist · 2026-07-09T08:13:27Z

-insert into tp_time(c_date, c_datetime, c_timestamp, c_time, c_year)
-values ('2020-02-20', '2020-02-20 02:20:20', '2020-02-20 02:20:20', '02:20:20', '2020');
+insert into tp_time(c_date, c_datetime, c_timestamp, c_time, c_year, c_txt)
+values ('2020-02-20', '2020-02-20 02:20:20', '2020-02-20 02:20:20', '02:20:20', '2020','cc');


There is a missing space after the comma before 'cc'. Please add a space to keep the formatting consistent with the other insert statements in this file.

values ('2020-02-20', '2020-02-20 02:20:20', '2020-02-20 02:20:20', '02:20:20', '2020', 'cc');

Signed-off-by: wk989898 <nhsmwk@gmail.com>

ti-chi-bot · 2026-07-09T08:22:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [3AceShowHand,lidezhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2026-07-09T08:22:10Z

[LGTM Timeline notifier]

Timeline:

2026-07-09 08:22:02.137860335 +0000 UTC m=+269908.173955391: ☑️ agreed by 3AceShowHand.
2026-07-09 08:22:09.272611699 +0000 UTC m=+269915.308706765: ☑️ agreed by lidezhu.

ti-chi-bot · 2026-07-09T08:37:03Z

@wk989898: You cannot manually add or delete the cherry pick branch category labels. It will be added automatically by bot when the PR is created.

Details

In response to adding label named type/cherry-pick-for-release-nextgen-202603.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

wk989898 · 2026-07-09T09:21:51Z

/retest

ti-chi-bot · 2026-07-09T09:51:43Z

In response to a cherrypick label: new pull request created to branch release-8.5: #5607.

wk989898 · 2026-07-09T11:03:53Z

/cherry-pick release-nextgen-202603

ti-chi-bot · 2026-07-09T11:04:32Z

@wk989898: new pull request created to branch release-nextgen-202603: #5609.

Details

In response to this:

/cherry-pick release-nextgen-202603

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

* init Signed-off-by: wk989898 <nhsmwk@gmail.com> * update Signed-off-by: wk989898 <nhsmwk@gmail.com> * update Signed-off-by: wk989898 <nhsmwk@gmail.com> --------- Signed-off-by: wk989898 <nhsmwk@gmail.com> Co-authored-by: wk989898 <nhsmwk@gmail.com>

init

7194e3b

Signed-off-by: wk989898 <nhsmwk@gmail.com>

ti-chi-bot Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 9, 2026

gemini-code-assist Bot reviewed Jul 9, 2026

View reviewed changes

update

6466bab

Signed-off-by: wk989898 <nhsmwk@gmail.com>

3AceShowHand approved these changes Jul 9, 2026

View reviewed changes

ti-chi-bot Bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 9, 2026

wk989898 changed the title ~~sink: add test case in debezium protocol~~ test: add test case in debezium protocol Jul 9, 2026

lidezhu approved these changes Jul 9, 2026

View reviewed changes

ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 9, 2026

wk989898 added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. type/cherry-pick-for-release-nextgen-202603 labels Jul 9, 2026

ti-chi-bot Bot removed the type/cherry-pick-for-release-nextgen-202603 label Jul 9, 2026

wk989898 added the need-cherry-pick-release-nextgen-202603 label Jul 9, 2026

ti-chi-bot Bot merged commit 99a351f into pingcap:master Jul 9, 2026
25 checks passed

ti-chi-bot mentioned this pull request Jul 9, 2026

test: add test case in debezium protocol (#5606) #5607

Open

ti-chi-bot mentioned this pull request Jul 9, 2026

test: add test case in debezium protocol (#5606) #5609

Merged

Uh oh!

Conversation

wk989898 commented Jul 9, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot Bot commented Jul 9, 2026

Uh oh!

ti-chi-bot Bot commented Jul 9, 2026

[LGTM Timeline notifier]

Uh oh!

ti-chi-bot Bot commented Jul 9, 2026

Uh oh!

wk989898 commented Jul 9, 2026

Uh oh!

Uh oh!

ti-chi-bot commented Jul 9, 2026

Uh oh!

wk989898 commented Jul 9, 2026

Uh oh!

ti-chi-bot commented Jul 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wk989898 commented Jul 9, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 9, 2026 •

edited

Loading