common: update TiDB TableInfo shared schema guard (#5652) - #5741
Conversation
Record the new table-level engine and storage class fields after reviewing that they do not affect TiCDC shared column schema.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lidezhu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* This is an automated cherry-pick of #5491 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * coordinator: resolve v8.5.7 cherry-pick conflicts * common: update TiDB TableInfo shared schema guard (#5652) (#5741) close #5740 --------- Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Co-authored-by: dongmen <20351731+asddongmen@users.noreply.github.com> Co-authored-by: dongmen <414110582@qq.com>
This is an automated cherry-pick of #5652
What problem does this PR solve?
Issue Number: close #5740
Background:
The
pull-unit-testjob for PR #5643 fails inTestLatestTiDBTableInfoSharedSchemaGuardafter TiDB addedEngineAttribute,StorageClassTier, andStorageClassTransitionstomodel.TableInfo.Motivation:
The guard intentionally tracks upstream struct changes so each new field is
reviewed before TiCDC accepts the contract. These fields describe table-level
engine and storage-class settings. They do not affect columns, indexes, handle
flags, row decoding, or the shared column schema used by TiCDC.
What is changed and how it works?
TableInfocontract.hashing or equality.
Check List
Tests
go test ./pkg/common -run '^TestLatestTiDBTableInfoSharedSchemaGuard$' -count=1go test ./pkg/common -count=1make fmtQuestions
Will it cause performance regression or break compatibility?
No. This only updates a test guard after reviewing table-level metadata that is
outside TiCDC's shared column schema.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note
Summary by CodeRabbit