Skip to content

common: update TiDB TableInfo shared schema guard (#5652) - #5741

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:release-8.5from
ti-chi-bot:cherry-pick-5652-to-release-8.5
Jul 25, 2026
Merged

common: update TiDB TableInfo shared schema guard (#5652)#5741
ti-chi-bot[bot] merged 1 commit into
pingcap:release-8.5from
ti-chi-bot:cherry-pick-5652-to-release-8.5

Conversation

@ti-chi-bot

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #5652

What problem does this PR solve?

Issue Number: close #5740

Background:
The pull-unit-test job for PR #5643 fails in
TestLatestTiDBTableInfoSharedSchemaGuard after TiDB added
EngineAttribute, StorageClassTier, and StorageClassTransitions to
model.TableInfo.

Motivation:
The guard intentionally tracks upstream struct changes so each new field is
reviewed before TiCDC accepts the contract. These fields describe table-level
engine and storage-class settings. They do not affect columns, indexes, handle
flags, row decoding, or the shared column schema used by TiCDC.

What is changed and how it works?

  • Add the three reviewed TiDB fields to the expected TableInfo contract.
  • Document why the fields do not need to participate in shared column schema
    hashing or equality.

Check List

Tests

  • Unit test
    • go test ./pkg/common -run '^TestLatestTiDBTableInfoSharedSchemaGuard$' -count=1
    • go test ./pkg/common -count=1
    • make fmt

Questions

Will it cause performance regression or break compatibility?

No. This only updates a test guard after reviewing table-level metadata that is
outside TiCDC's shared column schema.

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note

None

Summary by CodeRabbit

  • Tests
    • Updated schema compatibility checks to include newly supported table storage settings.
    • Adjusted field ordering validation for table metadata.

Record the new table-level engine and storage class fields after reviewing that they do not affect TiCDC shared column schema.
@ti-chi-bot ti-chi-bot added lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Jul 25, 2026
@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5eebda01-b312-4fab-94a8-1099f278d3fa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 25, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 25, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Jul 25, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit 1adf132 into pingcap:release-8.5 Jul 25, 2026
20 checks passed
asddongmen pushed a commit to ti-chi-bot/ticdc-1 that referenced this pull request Jul 28, 2026
asddongmen added a commit that referenced this pull request Jul 28, 2026
* This is an automated cherry-pick of #5491

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* coordinator: resolve v8.5.7 cherry-pick conflicts

* common: update TiDB TableInfo shared schema guard (#5652) (#5741)

close #5740

---------

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Co-authored-by: dongmen <20351731+asddongmen@users.noreply.github.com>
Co-authored-by: dongmen <414110582@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants