Skip to content

add integration test for reparo (#416)#447

Merged
WangXiangUSTC merged 4 commits intorelease-2.1from
xiang/cherry-pick-2
Jan 22, 2019
Merged

add integration test for reparo (#416)#447
WangXiangUSTC merged 4 commits intorelease-2.1from
xiang/cherry-pick-2

Conversation

@WangXiangUSTC
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

add integration test for reparo

What is changed and how it works?

git cherry-pick

Check List

Tests

  • Integration test

@WangXiangUSTC
Copy link
Copy Markdown
Contributor Author

/run-all-tests

1 similar comment
@WangXiangUSTC
Copy link
Copy Markdown
Contributor Author

/run-all-tests

@WangXiangUSTC
Copy link
Copy Markdown
Contributor Author

/run-all-tests

@IANTHEREAL
Copy link
Copy Markdown
Collaborator

what's reason of CI failing? should we fix CI script?

@WangXiangUSTC
Copy link
Copy Markdown
Contributor Author

/run-all-tests

@WangXiangUSTC
Copy link
Copy Markdown
Contributor Author

/run-all-tests

@WangXiangUSTC
Copy link
Copy Markdown
Contributor Author

@GregoryIan sleep time is too slow, add sleep time and run success.

Comment thread tests/reparo/reparo.toml Outdated
Copy link
Copy Markdown
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@IANTHEREAL
Copy link
Copy Markdown
Collaborator

LGTM

@WangXiangUSTC WangXiangUSTC merged commit ca1a82e into release-2.1 Jan 22, 2019
@WangXiangUSTC WangXiangUSTC deleted the xiang/cherry-pick-2 branch January 25, 2019 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants