Skip to content

ddl: fix drop index failed when index contain auto_increment column and more than 2 index contain auto_increment_column (#12230)#12345

Merged
sre-bot merged 3 commits intopingcap:release-3.1from
sre-bot:release-3.1-2f70d3813f03
Sep 24, 2019
Merged

ddl: fix drop index failed when index contain auto_increment column and more than 2 index contain auto_increment_column (#12230)#12345
sre-bot merged 3 commits intopingcap:release-3.1from
sre-bot:release-3.1-2f70d3813f03

Conversation

@sre-bot
Copy link
Copy Markdown
Contributor

@sre-bot sre-bot commented Sep 24, 2019

cherry-pick #12230 to release-3.1


What problem does this PR solve?

create table t (a int auto_increment,b int, unique index (a));
alter table t add index (a,b);
alter table t drop index a; – should execute successful, mysql will sucess.
(1075, u'Incorrect table definition; there can be only one auto column and it must be defined as a key')

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

  • DDL: Fix the issue that drop index on auto_increment column failed when table has more than 2 indexes that contain auto_increment column.

@sre-bot
Copy link
Copy Markdown
Contributor Author

sre-bot commented Sep 24, 2019

/run-all-tests

Copy link
Copy Markdown
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 24, 2019
Copy link
Copy Markdown
Contributor

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Sep 24, 2019
@sre-bot
Copy link
Copy Markdown
Contributor Author

sre-bot commented Sep 24, 2019

Your auto merge job has been accepted, waiting for 12351, 12354

@sre-bot
Copy link
Copy Markdown
Contributor Author

sre-bot commented Sep 24, 2019

/run-all-tests

@sre-bot sre-bot merged commit 93d079f into pingcap:release-3.1 Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants