Skip to content

*: Remove conversion function#14

Merged
ngaut merged 1 commit into
masterfrom
shenli/dev-conversion
Sep 6, 2015
Merged

*: Remove conversion function#14
ngaut merged 1 commit into
masterfrom
shenli/dev-conversion

Conversation

@shenli
Copy link
Copy Markdown
Member

@shenli shenli commented Sep 6, 2015

It is useless in MySQL and will cause conflict with
year/time/datetime/date function.

@shenli
*: Remove conversion function
ced00cc 
It is useless in MySQL and will cause conflict with
year/time/datetime/date function.
@qiuyesuifeng
Copy link
Copy Markdown
Member

qiuyesuifeng commented Sep 6, 2015

LGTM

2 similar comments
@coocood
Copy link
Copy Markdown
Member

coocood commented Sep 6, 2015

LGTM

@siddontang
Copy link
Copy Markdown
Member

siddontang commented Sep 6, 2015

LGTM

ngaut added a commit that referenced this pull request Sep 6, 2015
@ngaut
Merge pull request #14 from pingcap/shenli/dev-conversion
397f8ad 
*: Remove conversion function
@ngaut ngaut merged commit 397f8ad into master Sep 6, 2015
@ngaut ngaut deleted the shenli/dev-conversion branch September 6, 2015 10:26
francis0407 pushed a commit to francis0407/tidb that referenced this pull request Apr 11, 2020
@SeaRise
Merge pull request pingcap#14 from pingcap/master
63e1f5d 
update
@mahjonp mahjonp mentioned this pull request Aug 6, 2020
Open
YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Apr 23, 2021
@silentsai @huachaohuang
modify verification handling (pingcap#14)
8cd68cc
YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Apr 23, 2021
Merge pull request pingcap#14 from NingLin-P/more-integration-test
feb1191 
change test config
ichn-hu added a commit to ichn-hu/tidb that referenced this pull request May 10, 2021
@ichn-hu
Merge pull request pingcap#14 from ti-srebot/ichn-hu-patch-1
01889ad 
Update aggregate.go
xhebox pushed a commit to xhebox/tidb that referenced this pull request Sep 28, 2021
@winkyao @zz-jason
[parser] *: add ActionModifyTableCharsetAndCollate to support alter t…
f99a235 
…able charset and collate (pingcap#14)
xhebox pushed a commit to xhebox/tidb that referenced this pull request Oct 8, 2021
@winkyao @xhebox
[parser] *: add ActionModifyTableCharsetAndCollate to support alter t…
652aeab 
…able charset and collate (pingcap#14)
ti-chi-bot pushed a commit that referenced this pull request Oct 9, 2021
@winkyao @ti-chi-bot
[parser] *: add ActionModifyTableCharsetAndCollate to support alter t…
3048ced 
…able charset and collate (#14)
okJiang pushed a commit to okJiang/tidb that referenced this pull request Oct 19, 2021
@kennytm @tangenta
.travis.yml: enable CI and coverage (pingcap#14)
6342838
crazycs520 pushed a commit to crazycs520/tidb that referenced this pull request Jan 7, 2022
@Xuanwo
Merge pull request pingcap#14 from TiInterstellar/zstd
d544a24 
dumpling/parquet: Use zstd instead
@Defined2014 Defined2014 mentioned this pull request Mar 29, 2022
Closed
12 tasks
iosmanthus pushed a commit to iosmanthus/tidb that referenced this pull request Aug 22, 2022
@disksing
apply patches to release-6.2 (pingcap#14)
e28ae8c 
Signed-off-by: disksing <i@disksing.com>
JmPotato pushed a commit to JmPotato/tidb that referenced this pull request Dec 5, 2022
@BornChanger @nolouch
meta: use different key to seperate DDL jobs of tenants (pingcap#14)
5815591 
Signed-off-by: BornChanger <dawn_catcher@126.com>
ywqzzy pushed a commit to ywqzzy/tidb that referenced this pull request Jul 17, 2023
@wjhuang2016
Merge pull request pingcap#14 from tangenta/new_writer-4
abbfb85 
fix import key not in region
guoshouyan pushed a commit to guoshouyan/tidb that referenced this pull request Mar 5, 2024
@Tema
increase schema cache size (pingcap#14)
c5b69b0 
Co-authored-by: artem_danilov <artem_danilov@airbnb.com>
crazycs520 pushed a commit that referenced this pull request Oct 30, 2025
fix orc integration tests (#14)
7904dfb 
Signed-off-by: joccau <zak.zhao@pingcap.cn>

<!--

Thank you for contributing to TiDB!

PR Title Format:
1. pkg [, pkg2, pkg3]: what's changed
2. *: what's changed

-->

### What problem does this PR solve?
<!--

Please create an issue first to describe the problem.

There MUST be one line starting with "Issue Number:  " and
linking the relevant issues via the "close" or "ref".

For more info, check https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/contribute-code.html#referring-to-an-issue.

-->

Issue Number: close #xxx

Problem Summary:

### What changed and how does it work?

### Check List

Tests <!-- At least one of them must be included. -->

- [ ] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test
  > - [ ] I checked and no code files have been changed.
  > <!-- Or your custom  "No need to test" reasons -->

Side effects

- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility

Documentation

- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility

### Release note

<!-- compatibility change, improvement, bugfix, and new feature need a release note -->

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

```release-note
None
```

Reviewed-on: https://git.pingcap.net/pingkai/tidb/pulls/14
Reviewed-by: bear.c <bear.c@pingcap.cn>
Co-authored-by: joccau <zak.zhao@pingcap.cn>
Co-committed-by: joccau <zak.zhao@pingcap.cn>
crazycs520 pushed a commit that referenced this pull request Oct 30, 2025
revert 7904dfb
3861f8c 
revert fix orc integration tests (#14)

Signed-off-by: joccau <zak.zhao@pingcap.cn>

<!--

Thank you for contributing to TiDB!

PR Title Format:
1. pkg [, pkg2, pkg3]: what's changed
2. *: what's changed

-->

### What problem does this PR solve?
<!--

Please create an issue first to describe the problem.

There MUST be one line starting with "Issue Number:  " and
linking the relevant issues via the "close" or "ref".

For more info, check https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/contribute-code.html#referring-to-an-issue.

-->

Issue Number: close #xxx

Problem Summary:

### What changed and how does it work?

### Check List

Tests <!-- At least one of them must be included. -->

- [ ] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test
  > - [ ] I checked and no code files have been changed.
  > <!-- Or your custom  "No need to test" reasons -->

Side effects

- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility

Documentation

- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility

### Release note

<!-- compatibility change, improvement, bugfix, and new feature need a release note -->

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

```release-note
None
```

Reviewed-on: https://git.pingcap.net/pingkai/tidb/pulls/14
Reviewed-by: bear.c <bear.c@pingcap.cn>
Co-authored-by: joccau <zak.zhao@pingcap.cn>
Co-committed-by: joccau <zak.zhao@pingcap.cn>
solotzg pushed a commit to solotzg/tidb that referenced this pull request Mar 9, 2026
@windtalker
ddl: avoid inheriting flags in mv log (pingcap#14)
edb7ff3
ti-chi-bot pushed a commit that referenced this pull request Mar 11, 2026
@windtalker
ddl: avoid inheriting flags in mv log (#14)
3f64132
solotzg pushed a commit to solotzg/tidb that referenced this pull request Mar 12, 2026
@windtalker
ddl: avoid inheriting flags in mv log (pingcap#14)
ed237f6
ti-chi-bot pushed a commit that referenced this pull request Mar 12, 2026
@windtalker
ddl: avoid inheriting flags in mv log (#14)
242b8c2
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 13, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@22d537c). Learn more about missing BASE report.

⚠️ Current head 68d0945 differs from pull request most recent head ced00cc

Please upload reports for the commit ced00cc to get more accurate results.

Additional details and impacted files 
@@             Coverage Diff             @@
##             master        #14   +/-   ##
===========================================
  Coverage          ?   52.1196%           
===========================================
  Files             ?       1818           
  Lines             ?     653282           
  Branches          ?          0           
===========================================
  Hits              ?     340488           
  Misses            ?     285998           
  Partials          ?      26796
Flag Coverage Δ
integration 24.3744% <ø> (?)
unit 64.9125% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8145% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 55.4945% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gengliqi pushed a commit to gengliqi/tidb that referenced this pull request Mar 13, 2026
@windtalker @gengliqi
ddl: avoid inheriting flags in mv log (pingcap#14)
191e006
@takaidohigasi takaidohigasi mentioned this pull request Apr 24, 2026
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shenli @qiuyesuifeng @coocood @siddontang @ngaut