Skip to content

statistics: use histogram buckets bounds to enhance string match functions estimation#40338

Merged
ti-chi-bot merged 9 commits intopingcap:masterfrom
time-and-fate:s13-like-estimation-use-bucket-bound
Feb 28, 2023
Merged

statistics: use histogram buckets bounds to enhance string match functions estimation#40338
ti-chi-bot merged 9 commits intopingcap:masterfrom
time-and-fate:s13-like-estimation-use-bucket-bound

Conversation

@time-and-fate
Copy link
Copy Markdown
Member

@time-and-fate time-and-fate commented Jan 5, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #36209

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Jan 5, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 5, 2023
@time-and-fate time-and-fate mentioned this pull request Jan 5, 2023
Merged
12 tasks
@time-and-fate time-and-fate changed the title statistics: [WIP] use histogram buckets bounds to enhance string match functions estimation statistics: use histogram buckets bounds to enhance string match functions estimation Feb 16, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 28, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 28, 2023
@winoros
Copy link
Copy Markdown
Member

winoros commented Feb 28, 2023

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Feb 28, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 68466c2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 28, 2023
@ti-chi-bot ti-chi-bot merged commit 96e345d into pingcap:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qw4990 qw4990 qw4990 approved these changes

@winoros winoros winoros approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@time-and-fate @ti-chi-bot @winoros @qw4990