util: Change the output dir of the PLAN REPLAYER to be temp_dir by mengxian-li · Pull Request #58228 · pingcap/tidb

mengxian-li · 2024-12-13T00:14:00Z

What problem does this PR solve?

Issue Number: close #55513

Problem Summary:
@Tema

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Verified in a test cluster that the PLAN REPLAYER worked:

use test;
mysql> create table replayer_test(a int, b int);
mysql> insert into replayer_test values(1,1), (2, 2), (3, 3);
mysql> analyze table replayer_test;
mysql> plan replayer dump explain select * from replayer_test;
+-----------------------------------------------------------+
| File_token                                                |
+-----------------------------------------------------------+
| replayer_3kAIFhAJ2gJPs9qLL__K4Q==_1734048775715226847.zip |
+-----------------------------------------------------------+
1 row in set (0.17 sec)

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

sre-bot · 2024-12-13T00:14:08Z

All committers have signed the CLA.

ti-chi-bot · 2024-12-13T00:14:10Z

Welcome @mengxian-li!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to pingcap/tidb. 😃

ti-chi-bot · 2024-12-13T00:14:11Z

Hi @mengxian-li. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2024-12-13T00:14:18Z

Hi @mengxian-li. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hawkingrei · 2024-12-13T02:50:13Z

/ok-to-test

codecov · 2024-12-13T03:11:20Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.5573%. Comparing base (22c91d0) to head (4f66788).
Report is 1220 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #58228        +/-   ##
================================================
+ Coverage   73.2085%   74.5573%   +1.3488%     
================================================
  Files          1679       1712        +33     
  Lines        462531     478174     +15643     
================================================
+ Hits         338612     356514     +17902     
+ Misses       103136     100395      -2741     
- Partials      20783      21265       +482

Flag	Coverage Δ
integration	`46.4926% <100.0000%> (?)`
unit	`73.4789% <100.0000%> (+0.8681%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`∅ <ø> (∅)`
parser	`∅ <ø> (∅)`
br	`47.1740% <ø> (+0.0154%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mengxian-li · 2024-12-13T22:39:01Z

/retest

mengxian-li · 2024-12-13T22:43:36Z

/test fast_test_tiprow

tiprow · 2024-12-13T22:44:15Z

@ti-chi-bot[bot]: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test fast_test_tiprow_ddlargsv1
/test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

fast_test_tiprow
tidb_parser_test

Details

In response to this:

@mengxian-li: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-integration-e2e-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-unit-test-ddlv1
/test unit-test
The following commands are available to trigger optional jobs:
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-sqllogic-test
/test pull-tiflash-test
Use /test all to run the following jobs that were automatically triggered:
pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_integration_e2e_test
pingcap/tidb/pull_mysql_client_test
In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mengxian-li · 2024-12-13T22:45:14Z

/test all

mengxian-li · 2024-12-13T23:30:57Z

Looks like the fast_test_tiprow failed with:

FATAL: Could not find system javabase. Ensure JAVA_HOME is set, or javac is on your PATH.

@hawkingrei Do you have idea of what's going wrong there?

mengxian-li · 2024-12-14T01:07:54Z

/test fast_test_tiprow

tiprow · 2024-12-14T01:08:31Z

@ti-chi-bot[bot]: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test fast_test_tiprow_ddlargsv1
/test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

fast_test_tiprow
tidb_parser_test

Details

In response to this:

@mengxian-li: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-integration-e2e-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-unit-test-ddlv1
/test unit-test
The following commands are available to trigger optional jobs:
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-sqllogic-test
/test pull-tiflash-test
Use /test all to run the following jobs that were automatically triggered:
pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_integration_e2e_test
pingcap/tidb/pull_mysql_client_test
In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mengxian-li · 2024-12-16T18:18:23Z

/test fast_test_tiprow

ti-chi-bot · 2024-12-16T18:18:40Z

@mengxian-li: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build

/test check-dev

/test check-dev2

/test mysql-test

/test pull-br-integration-test

/test pull-integration-ddl-test

/test pull-integration-e2e-test

/test pull-lightning-integration-test

/test pull-mysql-client-test

/test pull-unit-test-ddlv1

/test unit-test

The following commands are available to trigger optional jobs:

/test pingcap/tidb/canary_ghpr_unit_test

/test pull-common-test

/test pull-e2e-test

/test pull-integration-common-test

/test pull-integration-copr-test

/test pull-integration-jdbc-test

/test pull-integration-mysql-test

/test pull-integration-nodejs-test

/test pull-integration-python-orm-test

/test pull-sqllogic-test

/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build

pingcap/tidb/ghpr_check

pingcap/tidb/ghpr_check2

pingcap/tidb/ghpr_mysql_test

pingcap/tidb/ghpr_unit_test

pingcap/tidb/pull_integration_ddl_test

pingcap/tidb/pull_integration_e2e_test

pingcap/tidb/pull_mysql_client_test

Details

In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2024-12-16T18:19:01Z

@ti-chi-bot[bot]: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test fast_test_tiprow_ddlargsv1
/test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

fast_test_tiprow
tidb_parser_test

Details

In response to this:

@mengxian-li: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-integration-e2e-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-unit-test-ddlv1
/test unit-test
The following commands are available to trigger optional jobs:
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-sqllogic-test
/test pull-tiflash-test
Use /test all to run the following jobs that were automatically triggered:
pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_integration_e2e_test
pingcap/tidb/pull_mysql_client_test
In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hawkingrei · 2024-12-17T03:36:03Z

@mengxian-li You need to sync code with master.

Signed-off-by: mengxian-li <ranylmx@gmail.com>

mengxian-li · 2024-12-17T17:52:27Z

/test fast_test_tiprow

ti-chi-bot · 2024-12-17T17:52:44Z

@mengxian-li: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build

/test check-dev

/test check-dev2

/test mysql-test

/test pull-br-integration-test

/test pull-integration-ddl-test

/test pull-integration-e2e-test

/test pull-lightning-integration-test

/test pull-mysql-client-test

/test pull-unit-test-ddlv1

/test unit-test

The following commands are available to trigger optional jobs:

/test pingcap/tidb/canary_ghpr_unit_test

/test pull-common-test

/test pull-e2e-test

/test pull-integration-common-test

/test pull-integration-copr-test

/test pull-integration-jdbc-test

/test pull-integration-mysql-test

/test pull-integration-nodejs-test

/test pull-integration-python-orm-test

/test pull-sqllogic-test

/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build

pingcap/tidb/ghpr_check

pingcap/tidb/ghpr_check2

pingcap/tidb/ghpr_mysql_test

pingcap/tidb/ghpr_unit_test

pingcap/tidb/pull_integration_ddl_test

pingcap/tidb/pull_integration_e2e_test

pingcap/tidb/pull_mysql_client_test

Details

In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2024-12-17T17:53:06Z

@ti-chi-bot[bot]: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test fast_test_tiprow_ddlargsv1
/test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

fast_test_tiprow
tidb_parser_test

Details

In response to this:

@mengxian-li: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-integration-e2e-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-unit-test-ddlv1
/test unit-test
The following commands are available to trigger optional jobs:
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-sqllogic-test
/test pull-tiflash-test
Use /test all to run the following jobs that were automatically triggered:
pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_integration_e2e_test
pingcap/tidb/pull_mysql_client_test
In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mengxian-li · 2024-12-17T18:04:07Z

@hawkingrei I synced with master, but fast_test_tiprow still failed

hawkingrei · 2024-12-18T05:56:15Z

/retest

mengxian-li · 2024-12-18T19:52:59Z

@hawkingrei Could you stamp on the latest commit?

ti-chi-bot · 2024-12-19T03:45:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [hawkingrei,qw4990]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-12-19T03:45:10Z

[LGTM Timeline notifier]

Timeline:

2024-12-17 03:37:08.287840726 +0000 UTC m=+928018.376643269: ☑️ agreed by hawkingrei.
2024-12-19 03:45:09.539170681 +0000 UTC m=+1101299.627973224: ☑️ agreed by qw4990.

hawkingrei · 2024-12-19T03:46:37Z

@hawkingrei Could you stamp on the latest commit?

OK, I have checked it. it is great.

hawkingrei · 2024-12-20T05:42:06Z

/retest

ti-chi-bot · 2025-07-18T07:47:51Z

In response to a cherrypick label: new pull request created to branch release-8.5: #62497.

…) (#62497) close #55513

…cap#58228)

…cap#58228) X-Original-Commit: c307305

ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/invalid-title labels Dec 13, 2024

ti-chi-bot Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Dec 13, 2024

mengxian-li mentioned this pull request Dec 13, 2024

Allow to specify diagnostics folder #55513

Closed

lance6716 requested a review from hawkingrei December 13, 2024 02:02

ti-chi-bot Bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Dec 13, 2024

mengxian-li force-pushed the fix-replayer branch from 44a17b2 to 01ffb2f Compare December 13, 2024 22:35

mengxian-li force-pushed the fix-replayer branch 2 times, most recently from ebfab40 to 2dd5018 Compare December 13, 2024 23:23

hawkingrei changed the title ~~Change the output dir of the PLAN REPLAYER to be temp_dir~~ util: Change the output dir of the PLAN REPLAYER to be temp_dir Dec 16, 2024

ti-chi-bot Bot removed the do-not-merge/invalid-title label Dec 16, 2024

Change the output dir of the PLAN REPLAYER to be temp_dir.

4f66788

Signed-off-by: mengxian-li <ranylmx@gmail.com>

mengxian-li force-pushed the fix-replayer branch from 2dd5018 to 4f66788 Compare December 17, 2024 17:51

qw4990 approved these changes Dec 19, 2024

View reviewed changes

ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 19, 2024

pingcap deleted a comment from ti-chi-bot Bot Dec 19, 2024

ti-chi-bot Bot merged commit 220d5cb into pingcap:master Dec 20, 2024

ti-chi-bot Bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Jul 18, 2025

ti-chi-bot mentioned this pull request Jul 18, 2025

util: Change the output dir of the PLAN REPLAYER to be temp_dir (#58228) #62497

Merged

13 tasks

ti-chi-bot Bot pushed a commit that referenced this pull request Jul 18, 2025

util: Change the output dir of the PLAN REPLAYER to be temp_dir (#58228…

ae7dd0d

…) (#62497) close #55513

hawkingrei mentioned this pull request Sep 24, 2025

planner: plan relayer is compatible with the old mode #63730

Merged

13 tasks

This was referenced Sep 26, 2025

planner: plan relayer is compatible with the old mode (#63730) #63773

Merged

planner: plan relayer is compatible with the old mode (#63730) #63798

Merged

pantheon-ai Bot mentioned this pull request Jan 8, 2026

tidb_analyze_disql_scan_concurrency may slow down manual analyze for upgraded cluster #65423

Closed

AvaisP pushed a commit to AvaisP/tidb that referenced this pull request Mar 2, 2026

util: Change the output dir of the PLAN REPLAYER to be temp_dir (ping…

58ee009

…cap#58228)

AvaisP pushed a commit to AvaisP/tidb that referenced this pull request Mar 2, 2026

util: Change the output dir of the PLAN REPLAYER to be temp_dir (ping…

5aedaab

…cap#58228)

AvaisP pushed a commit to AvaisP/tidb that referenced this pull request Mar 4, 2026

util: Change the output dir of the PLAN REPLAYER to be temp_dir (ping…

18d6e15

…cap#58228)

ClamChowderTiDB pushed a commit to ClamChowderTiDB/tidb that referenced this pull request Mar 31, 2026

util: Change the output dir of the PLAN REPLAYER to be temp_dir (ping…

7f5f157

…cap#58228) X-Original-Commit: c307305

Conversation

mengxian-li commented Dec 13, 2024

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

sre-bot commented Dec 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ti-chi-bot Bot commented Dec 13, 2024

Uh oh!

ti-chi-bot Bot commented Dec 13, 2024

Uh oh!

tiprow Bot commented Dec 13, 2024

Uh oh!

hawkingrei commented Dec 13, 2024

Uh oh!

codecov Bot commented Dec 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mengxian-li commented Dec 13, 2024

Uh oh!

mengxian-li commented Dec 13, 2024

Uh oh!

tiprow Bot commented Dec 13, 2024

Uh oh!

mengxian-li commented Dec 13, 2024

Uh oh!

mengxian-li commented Dec 13, 2024

Uh oh!

mengxian-li commented Dec 14, 2024

Uh oh!

tiprow Bot commented Dec 14, 2024

Uh oh!

mengxian-li commented Dec 16, 2024

Uh oh!

ti-chi-bot Bot commented Dec 16, 2024

Uh oh!

tiprow Bot commented Dec 16, 2024

Uh oh!

hawkingrei commented Dec 17, 2024

Uh oh!

mengxian-li commented Dec 17, 2024

Uh oh!

ti-chi-bot Bot commented Dec 17, 2024

Uh oh!

tiprow Bot commented Dec 17, 2024

Uh oh!

mengxian-li commented Dec 17, 2024

Uh oh!

hawkingrei commented Dec 18, 2024

Uh oh!

mengxian-li commented Dec 18, 2024

Uh oh!

ti-chi-bot Bot commented Dec 19, 2024

Uh oh!

ti-chi-bot Bot commented Dec 19, 2024

[LGTM Timeline notifier]

Uh oh!

hawkingrei commented Dec 19, 2024

Uh oh!

hawkingrei commented Dec 20, 2024

Uh oh!

ti-chi-bot commented Jul 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sre-bot commented Dec 13, 2024 •

edited

Loading

codecov Bot commented Dec 13, 2024 •

edited

Loading