statistics: add Destroy method and handle session recycling#59546
statistics: add Destroy method and handle session recycling#59546ti-chi-bot[bot] merged 23 commits intopingcap:masterfrom
Conversation
Signed-off-by: Rustin170506 <techregister@pm.me>
…ntext Signed-off-by: Rustin170506 <techregister@pm.me>
…ce and implement it in relevant structs Signed-off-by: Rustin170506 <techregister@pm.me>
…ntext packages Signed-off-by: Rustin170506 <techregister@pm.me>
Signed-off-by: Rustin170506 <techregister@pm.me>
…nd statistics packages Signed-off-by: Rustin170506 <techregister@pm.me>
Signed-off-by: Rustin170506 <techregister@pm.me>
… decrement Signed-off-by: Rustin170506 <techregister@pm.me>
Signed-off-by: Rustin170506 <techregister@pm.me>
|
/retest |
…t cases Signed-off-by: Rustin170506 <techregister@pm.me>
Signed-off-by: Rustin170506 <techregister@pm.me>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #59546 +/- ##
================================================
+ Coverage 73.0249% 74.9155% +1.8905%
================================================
Files 1693 1742 +49
Lines 468066 480776 +12710
================================================
+ Hits 341805 360176 +18371
+ Misses 105227 98081 -7146
- Partials 21034 22519 +1485
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Rustin170506 <techregister@pm.me>
|
Tested locally: |
Signed-off-by: Rustin170506 <techregister@pm.me>
0xPoe
left a comment
There was a problem hiding this comment.
🔢 Self-check (PR reviewed by myself and ready for feedback.)
…grams Signed-off-by: Rustin170506 <techregister@pm.me>
32ae7af to
ca7c82f
Compare
|
/retest |
1 similar comment
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, tangenta, tiancaiamao, time-and-fate, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #59524 close #59560
Problem Summary:
What changed and how does it work?
ref #59522
This is an alternative API design to solve the problem. I believe explicitly using destroy instead of exposing implementation details is a better approach to fix it.
I also added more logs to help us inspect error cases.
Note: This PR doesn’t address the root cause of the issues; it only ensures that we don’t encounter OOM problems. We still need to figure out why we’re running into this kind of stats loading.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.