Skip to content

planner: return error if binding sql is too long#59982

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
qw4990:binding-err
Mar 10, 2025
Merged

planner: return error if binding sql is too long#59982
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
qw4990:binding-err

Conversation

@qw4990
Copy link
Copy Markdown
Contributor

@qw4990 qw4990 commented Mar 10, 2025

What problem does this PR solve?

Issue Number: ref #51347

[Problem Summary: planner: refactor some code related to binding
](planner: return error if binding sql is too long)

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/planner SIG: Planner labels Mar 10, 2025
@tiprow
Copy link
Copy Markdown

tiprow Bot commented Mar 10, 2025

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 10, 2025
Copy link
Copy Markdown
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a to-do comment

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Mar 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 10, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Mar 10, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-10 07:55:46.524436765 +0000 UTC m=+169702.129965689: ☑️ agreed by hawkingrei.
  • 2025-03-10 08:05:50.675051843 +0000 UTC m=+170306.280580773: ☑️ agreed by AilinKid.

@qw4990
Copy link
Copy Markdown
Contributor Author

qw4990 commented Mar 10, 2025

/test check-dev

@tiprow
Copy link
Copy Markdown

tiprow Bot commented Mar 10, 2025

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qw4990
Copy link
Copy Markdown
Contributor Author

qw4990 commented Mar 10, 2025

/retest

@tiprow
Copy link
Copy Markdown

tiprow Bot commented Mar 10, 2025

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qw4990
Copy link
Copy Markdown
Contributor Author

qw4990 commented Mar 10, 2025

/retest

@tiprow
Copy link
Copy Markdown

tiprow Bot commented Mar 10, 2025

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.5226%. Comparing base (b72ff3b) to head (e86361f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59982        +/-   ##
================================================
+ Coverage   73.0771%   73.5226%   +0.4454%     
================================================
  Files          1702       1702                
  Lines        470092     470191        +99     
================================================
+ Hits         343530     345697      +2167     
+ Misses       105392     103334      -2058     
+ Partials      21170      21160        -10     
Flag Coverage Δ
integration 42.7641% <40.0000%> (?)
unit 72.3199% <70.0000%> (+0.0374%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 47.2310% <ø> (+0.0083%) ⬆️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot Bot merged commit f8f667e into pingcap:master Mar 10, 2025
22 checks passed
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants