Skip to content

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #59985

What problem does this PR solve?

Issue Number: close #59963, close #59976

Problem Summary:

  1. The row container will not be closed if the exclusion panic.
  2. The results and cursor will not be reset if there is an error in cc.flush.

What changed and how does it work?

  1. Set the row container of stmt right after creating it. Therefore, it can be closed after closing the connection.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Mar 11, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 11, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tiancaiamao for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 11, 2025
@lybcodes
Copy link

/test pull-e2e-test

@tiprow
Copy link

tiprow bot commented Dec 11, 2025

@lybcodes: No presubmit jobs available for pingcap/tidb@release-7.1

Details

In response to this:

/test pull-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lybcodes
Copy link

/test pull-integration-binlog-test

@tiprow
Copy link

tiprow bot commented Dec 11, 2025

@lybcodes: No presubmit jobs available for pingcap/tidb@release-7.1

Details

In response to this:

/test pull-integration-binlog-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lybcodes
Copy link

/test pull-integration-common-test

@tiprow
Copy link

tiprow bot commented Dec 11, 2025

@lybcodes: No presubmit jobs available for pingcap/tidb@release-7.1

Details

In response to this:

/test pull-integration-common-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lybcodes
Copy link

/test pull-integration-copr-test

@tiprow
Copy link

tiprow bot commented Dec 11, 2025

@lybcodes: No presubmit jobs available for pingcap/tidb@release-7.1

Details

In response to this:

/test pull-integration-copr-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lybcodes
Copy link

/test pull-integration-ddl-test

@tiprow
Copy link

tiprow bot commented Dec 11, 2025

@lybcodes: No presubmit jobs available for pingcap/tidb@release-7.1

Details

In response to this:

/test pull-integration-ddl-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lybcodes
Copy link

/test pull-integration-jdbc-test

@tiprow
Copy link

tiprow bot commented Dec 11, 2025

@lybcodes: No presubmit jobs available for pingcap/tidb@release-7.1

Details

In response to this:

/test pull-integration-jdbc-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lybcodes
Copy link

/test pull-integration-mysql-test

@tiprow
Copy link

tiprow bot commented Dec 11, 2025

@lybcodes: No presubmit jobs available for pingcap/tidb@release-7.1

Details

In response to this:

/test pull-integration-mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 11, 2025

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 ec2bb7e link true /test check-dev2
idc-jenkins-ci-tidb/build ec2bb7e link true /test build
idc-jenkins-ci-tidb/unit-test ec2bb7e link true /test unit-test
idc-jenkins-ci-tidb/check_dev ec2bb7e link true /test check-dev
idc-jenkins-ci-tidb/mysql-test ec2bb7e link true /test mysql-test
pull-e2e-test ec2bb7e link false /test pull-e2e-test
pull-integration-common-test ec2bb7e link false /test pull-integration-common-test
pull-integration-ddl-test ec2bb7e link false /test pull-integration-ddl-test
pull-integration-binlog-test ec2bb7e link false /test pull-integration-binlog-test
pull-integration-jdbc-test ec2bb7e link false /test pull-integration-jdbc-test
pull-integration-copr-test ec2bb7e link false /test pull-integration-copr-test
pull-integration-mysql-test ec2bb7e link false /test pull-integration-mysql-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/cherry-pick-not-approved do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants