Skip to content

runaway: fix the issue where COOLDOWN/SWITCH_GROUP can't be triggered#60457

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
JmPotato:fix_runaway
Apr 15, 2025
Merged

runaway: fix the issue where COOLDOWN/SWITCH_GROUP can't be triggered#60457
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
JmPotato:fix_runaway

Conversation

@JmPotato
Copy link
Copy Markdown
Member

@JmPotato JmPotato commented Apr 9, 2025

What problem does this PR solve?

Issue Number: close #60404

Problem Summary:

Run the corresponding actions in BeforeCopRequest once it's marked by IdentifyInRunawaySettings.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
image image image

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue where `COOLDOWN`/`SWITCH_GROUP` can't be triggered with `QUERY_LIMIT`.

@JmPotato JmPotato requested review from glorv, lhy1024 and nolouch April 9, 2025 10:14
@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 9, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 44.11765% with 19 lines in your changes missing coverage. Please review.

Project coverage is 73.5172%. Comparing base (c9b33d6) to head (4e2e28d).
Report is 524 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #60457        +/-   ##
================================================
+ Coverage   73.0908%   73.5172%   +0.4263%     
================================================
  Files          1714       1714                
  Lines        474865     474916        +51     
================================================
+ Hits         347083     349145      +2062     
+ Misses       106433     104436      -1997     
+ Partials      21349      21335        -14     
Flag Coverage Δ
integration 42.6465% <0.0000%> (?)
unit 72.3316% <44.1176%> (+0.0295%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6553% <ø> (ø)
parser ∅ <ø> (∅)
br 47.2823% <ø> (+0.0083%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 10, 2025
@glorv
Copy link
Copy Markdown
Contributor

glorv commented Apr 10, 2025

/retest

@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 10, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 15, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 15, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-10 16:47:40.558706114 +0000 UTC m=+2361354.242942210: ☑️ agreed by glorv.
  • 2025-04-15 03:48:41.242955721 +0000 UTC m=+2746614.927191802: ☑️ agreed by nolouch.

…_LIMIT

Signed-off-by: JmPotato <github@ipotato.me>
@ti-chi-bot ti-chi-bot Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 15, 2025
Signed-off-by: JmPotato <github@ipotato.me>
@JmPotato
Copy link
Copy Markdown
Member Author

/test check-dev2

@tiprow
Copy link
Copy Markdown

tiprow Bot commented Apr 15, 2025

@JmPotato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@JmPotato
Copy link
Copy Markdown
Member Author

/test unit-test

@tiprow
Copy link
Copy Markdown

tiprow Bot commented Apr 15, 2025

@JmPotato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot merged commit ea52376 into pingcap:master Apr 15, 2025
24 checks passed
@JmPotato JmPotato deleted the fix_runaway branch April 15, 2025 05:49
@JmPotato
Copy link
Copy Markdown
Member Author

/cherry-pick release-8.5

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 15, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Copy Markdown
Member

@JmPotato: new pull request created to branch release-8.5: #60568.
But this PR has conflicts, please resolve them!

Details

In response to this:

/cherry-pick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 16, 2025
@ti-chi-bot ti-chi-bot Bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jul 8, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 8, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #62299.
But this PR has conflicts, please resolve them!

@ti-chi-bot ti-chi-bot Bot removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

COOLDOWN/SWITCH_GROUP/DRY_RUN actions don't work with QUERY_LIMIT

4 participants