-
Notifications
You must be signed in to change notification settings - Fork 6.1k
topsql: move fast plan check to beginning of observeStmtBeginForTopSQL when disable top sql (#60605) #60607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
topsql: move fast plan check to beginning of observeStmtBeginForTopSQL when disable top sql (#60605) #60607
Conversation
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #60607 +/- ##
================================================
Coverage ? 36.8461%
================================================
Files ? 1675
Lines ? 612840
Branches ? 0
================================================
Hits ? 225808
Misses ? 364871
Partials ? 22161
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@ti-chi-bot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #60605
What problem does this PR solve?
Issue Number: close #60604
Problem Summary: see #60604
What changed and how does it work?
The fast plan check is now performed at the very beginning of observeStmtBeginForTopSQL. This change skips the expensive GetPlanDigest call when TopSQL is disabled and the execution plan is a fast path, since point gets return early and the plan digest is only cached without further use.
For this optimization to take effect, TopSQL, slow log, and statement summary must be disabled.
Check List
Tests
before:
after (no
GetPlanDigestfound in flame graph):in our special edition of TiDB, sysbench point select QPS can have 2~3% increment
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.