Skip to content

Conversation

@solotzg
Copy link
Contributor

@solotzg solotzg commented Apr 17, 2025

What problem does this PR solve?

Issue Number: ref #58194

Problem Summary: shown in #58194

What changed and how does it work?

  • add design doc to introduce the new global memory control mechanism

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@solotzg solotzg marked this pull request as draft April 17, 2025 09:03
@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 17, 2025
@tiprow
Copy link

tiprow bot commented Apr 17, 2025

Hi @solotzg. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@solotzg solotzg changed the title [draft] [draft] design: TiDB Global Memory Arbitrator Apr 17, 2025
@solotzg solotzg changed the title [draft] design: TiDB Global Memory Arbitrator design: TiDB Global Memory Arbitrator Apr 18, 2025
@solotzg solotzg force-pushed the mem-arbitrator-desgin-doc branch from ef7877f to 364134c Compare April 24, 2025 06:55
@solotzg solotzg marked this pull request as ready for review April 24, 2025 06:58
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2025
@zanmato1984 zanmato1984 requested a review from Copilot April 25, 2025 05:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

@solotzg
Copy link
Contributor Author

solotzg commented May 19, 2025

/cc @gengliqi

@ti-chi-bot ti-chi-bot bot requested a review from gengliqi May 19, 2025 10:12
@solotzg
Copy link
Contributor Author

solotzg commented May 19, 2025

/cc @windtalker @wshwsh12

@ti-chi-bot ti-chi-bot bot requested review from windtalker and wshwsh12 May 19, 2025 10:13
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 19, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 26, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 26, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-19 09:17:46.410538082 +0000 UTC m=+349719.133717064: ☑️ agreed by guo-shaoge.
  • 2025-06-26 08:21:07.774174907 +0000 UTC m=+951120.497353889: ☑️ agreed by XuHuaiyu.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, wshwsh12, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [XuHuaiyu,guo-shaoge,wshwsh12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tiprow
Copy link

tiprow bot commented Jun 26, 2025

@solotzg: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tidb_parser_test bc51ab7 link true /test tidb_parser_test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit c2e1dfa into pingcap:master Jun 26, 2025
3 of 5 checks passed
@solotzg solotzg deleted the mem-arbitrator-desgin-doc branch June 26, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants