-
Notifications
You must be signed in to change notification settings - Fork 6.1k
workloadrepo: Add permission checks to workload repo's ADMIN command. #60642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workloadrepo: Add permission checks to workload repo's ADMIN command. #60642
Conversation
|
Hi @wddevries. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #60642 +/- ##
================================================
+ Coverage 73.0805% 74.0144% +0.9339%
================================================
Files 1715 1717 +2
Lines 475162 480556 +5394
================================================
+ Hits 347251 355681 +8430
+ Misses 106516 103609 -2907
+ Partials 21395 21266 -129
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terry1purcell, xhebox, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #58247
Problem Summary:
The "ADMIN CREATE WORKLOAD SNAPSHOT" command does not currently require that the user have any privileges.
What changed and how does it work?
This patch will make "SUPER" required for users to initiate a manual workload repository snapshots.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.