Skip to content

Conversation

@wddevries
Copy link
Contributor

@wddevries wddevries commented Apr 18, 2025

What problem does this PR solve?

Issue Number: ref #58247

Problem Summary:
The "ADMIN CREATE WORKLOAD SNAPSHOT" command does not currently require that the user have any privileges.

What changed and how does it work?

This patch will make "SUPER" required for users to initiate a manual workload repository snapshots.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 18, 2025
@tiprow
Copy link

tiprow bot commented Apr 18, 2025

Hi @wddevries. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.0144%. Comparing base (f31911c) to head (9709f21).
Report is 9 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #60642        +/-   ##
================================================
+ Coverage   73.0805%   74.0144%   +0.9339%     
================================================
  Files          1715       1717         +2     
  Lines        475162     480556      +5394     
================================================
+ Hits         347251     355681      +8430     
+ Misses       106516     103609      -2907     
+ Partials      21395      21266       -129     
Flag Coverage Δ
integration 43.1912% <0.0000%> (?)
unit 72.8759% <100.0000%> (+0.5685%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6553% <ø> (ø)
parser ∅ <ø> (∅)
br 48.0395% <ø> (+0.7513%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 18, 2025
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-tests-checked labels Apr 18, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 18, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-18 01:58:29.869041782 +0000 UTC m=+2999203.553277878: ☑️ agreed by zimulala.
  • 2025-04-18 06:00:00.400185236 +0000 UTC m=+3013694.084421332: ☑️ agreed by xhebox.

@terry1purcell
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terry1purcell, xhebox, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 18, 2025
@ti-chi-bot ti-chi-bot bot merged commit 99fcfad into pingcap:master Apr 18, 2025
24 checks passed
@wddevries wddevries deleted the workloadrepo_add_permissions branch June 5, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants