-
Notifications
You must be signed in to change notification settings - Fork 6.1k
executor: fix schema-table inconsistent issue in IS.tables (#60638)
#60643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix schema-table inconsistent issue in IS.tables (#60638)
#60643
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@tangenta This PR has conflicts, I have hold it. |
|
/unhold |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #60643 +/- ##
================================================
Coverage ? 56.9878%
================================================
Files ? 1770
Lines ? 628757
Branches ? 0
================================================
Hits ? 358315
Misses ? 246283
Partials ? 24159
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, joccau, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #60638
What problem does this PR solve?
Issue Number: close #60593
Problem Summary:
Previous sorting impl is problematic.
What changed and how does it work?
The original code mistakenly swapped the elements of
tableSlicemanually during sorting, causing it to be out of sync withschemaSlice. By merging the data and sorting them uniformly, the order consistency of the two is ensured, eliminating the data misalignment problem caused by manual swapping.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.