Skip to content

planner: make redact log test result ignore plan ID with explain format as brief.#60941

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
AilinKid:fix-redact-test
Apr 30, 2025
Merged

planner: make redact log test result ignore plan ID with explain format as brief.#60941
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
AilinKid:fix-redact-test

Conversation

@AilinKid
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref #60940

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

.
Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 29, 2025
@tiprow
Copy link
Copy Markdown

tiprow bot commented Apr 29, 2025

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@AilinKid AilinKid requested a review from hawkingrei April 29, 2025 15:22
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 29, 2025
@AilinKid
Copy link
Copy Markdown
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Apr 29, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.4289%. Comparing base (5faa749) to head (347a8a7).
Report is 34 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #60941        +/-   ##
================================================
+ Coverage   73.1219%   73.4289%   +0.3069%     
================================================
  Files          1718       1722         +4     
  Lines        476002     480850      +4848     
================================================
+ Hits         348062     353083      +5021     
+ Misses       106563     106280       -283     
- Partials      21377      21487       +110     
Flag Coverage Δ
integration 42.5900% <ø> (?)
unit 72.4586% <ø> (+0.0966%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7118% <ø> (ø)
parser ∅ <ø> (∅)
br 47.3824% <ø> (+0.0420%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 30, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 30, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-29 15:22:40.128478612 +0000 UTC m=+973903.940268987: ☑️ agreed by qw4990.
  • 2025-04-30 00:57:55.779849 +0000 UTC m=+1008419.591639377: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 23fa4b8 into pingcap:master Apr 30, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants