variable: sql_require_primary_key should require SYSTEM_VARIABLES_ADMIN #61829 | tidb-test=920d9bf1b1137cda1272bdd59ae527aee8067944

[Debra-He]

What problem does this PR solve?

Issue Number: close #61825

Problem Summary:

What changed and how does it work?

pick to #61829 hotfix

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sdojjy for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

Hi @Debra-He. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tiprow]

Hi @Debra-He. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Debra-He]

/test all

[ti-chi-bot]

@Debra-He: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tiprow]

@Debra-He: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[winkyao]

/ok-to-test

[ti-chi-bot]

@winkyao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tiprow]

@winkyao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[iamxy]

/ok-to-test

[winkyao]

/test all

[tiprow]

@winkyao: No presubmit jobs available for pingcap/tidb@release-6.5-20241112-v6.5.11

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[winkyao]

/test ?

[ti-chi-bot]

@winkyao: The following commands are available to trigger required jobs:

/test build

/test check-dev

/test check-dev2

/test mysql-test

/test unit-test

The following commands are available to trigger optional jobs:

/test pull-br-integration-test

/test pull-common-test

/test pull-e2e-test

/test pull-integration-binlog-test

/test pull-integration-common-test

/test pull-integration-copr-test

/test pull-integration-ddl-test

/test pull-integration-jdbc-test

/test pull-integration-mysql-test

/test pull-integration-tidb-tools-test

/test pull-sqllogic-test

/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/release-6.5/ghpr_build

pingcap/tidb/release-6.5/ghpr_check

pingcap/tidb/release-6.5/ghpr_check2

pingcap/tidb/release-6.5/ghpr_mysql_test

pingcap/tidb/release-6.5/ghpr_unit_test

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tiprow]

@winkyao: No presubmit jobs available for pingcap/tidb@release-6.5-20241112-v6.5.11

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tiprow]

@ti-chi-bot[bot]: No presubmit jobs available for pingcap/tidb@release-6.5-20241112-v6.5.11

Details

In response to this:

@winkyao: The following commands are available to trigger required jobs:

/test build

/test check-dev

/test check-dev2

/test mysql-test

/test unit-test

The following commands are available to trigger optional jobs:

/test pull-br-integration-test

/test pull-common-test

/test pull-e2e-test

/test pull-integration-binlog-test

/test pull-integration-common-test

/test pull-integration-copr-test

/test pull-integration-ddl-test

/test pull-integration-jdbc-test

/test pull-integration-mysql-test

/test pull-integration-tidb-tools-test

/test pull-sqllogic-test

/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/release-6.5/ghpr_build

pingcap/tidb/release-6.5/ghpr_check

pingcap/tidb/release-6.5/ghpr_check2

pingcap/tidb/release-6.5/ghpr_mysql_test

pingcap/tidb/release-6.5/ghpr_unit_test

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lance6716]

/test all

[winkyao]

/test pull-br-integration-test

[winkyao]

/test pull-common-test

[tiprow]

@lance6716: No presubmit jobs available for pingcap/tidb@release-6.5-20241112-v6.5.11

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tiprow]

@winkyao: No presubmit jobs available for pingcap/tidb@release-6.5-20241112-v6.5.11

Details

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tiprow]

@winkyao: No presubmit jobs available for pingcap/tidb@release-6.5-20241112-v6.5.11

Details

In response to this:

/test pull-common-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Debra-He]

/test unit-test

[tiprow]

@Debra-He: No presubmit jobs available for pingcap/tidb@release-6.5-20241112-v6.5.11

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Debra-He]

/test pull-e2e-test

[tiprow]

@Debra-He: No presubmit jobs available for pingcap/tidb@release-6.5-20241112-v6.5.11

Details

In response to this:

/test pull-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Debra-He]

/test pull-integration-binlog-test

[Debra-He]

/test pull-integration-common-test

[tiprow]

@Debra-He: No presubmit jobs available for pingcap/tidb@release-6.5-20241112-v6.5.11

Details

In response to this:

/test pull-integration-binlog-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Debra-He]

/test pull-integration-copr-test

[Debra-He]

/test pull-integration-ddl-test

[tiprow]

@Debra-He: No presubmit jobs available for pingcap/tidb@release-6.5-20241112-v6.5.11

Details

In response to this:

/test pull-integration-common-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tiprow]

@Debra-He: No presubmit jobs available for pingcap/tidb@release-6.5-20241112-v6.5.11

Details

In response to this:

/test pull-integration-copr-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Debra-He]

/test pull-integration-jdbc-test

[tiprow]

@Debra-He: No presubmit jobs available for pingcap/tidb@release-6.5-20241112-v6.5.11

Details

In response to this:

/test pull-integration-ddl-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Debra-He]

/test pull-integration-mysql-test

[tiprow]

@Debra-He: No presubmit jobs available for pingcap/tidb@release-6.5-20241112-v6.5.11

Details

In response to this:

/test pull-integration-jdbc-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Debra-He]

/test pull-integration-tidb-tools-test

[tiprow]

@Debra-He: No presubmit jobs available for pingcap/tidb@release-6.5-20241112-v6.5.11

Details

In response to this:

/test pull-integration-mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Debra-He]

/test pull-sqllogic-test

[tiprow]

@Debra-He: No presubmit jobs available for pingcap/tidb@release-6.5-20241112-v6.5.11

Details

In response to this:

/test pull-integration-tidb-tools-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Debra-He]

/test pull-tiflash-test

[tiprow]

@Debra-He: No presubmit jobs available for pingcap/tidb@release-6.5-20241112-v6.5.11

Details

In response to this:

/test pull-sqllogic-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tiprow]

@Debra-He: No presubmit jobs available for pingcap/tidb@release-6.5-20241112-v6.5.11

Details

In response to this:

/test pull-tiflash-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-6.5-20241112-v6.5.11@4f24620). Learn more about missing BASE report.

Additional details and impacted files

@@                        Coverage Diff                        @@
##             release-6.5-20241112-v6.5.11     #64264   +/-   ##
=================================================================
  Coverage                                ?   73.6245%           
=================================================================
  Files                                   ?       1097           
  Lines                                   ?     353006           
  Branches                                ?          0           
=================================================================
  Hits                                    ?     259899           
  Misses                                  ?      76373           
  Partials                                ?      16734           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[winkyao]

/retest

[ti-chi-bot]

@Debra-He: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-integration-copr-test	e494cc5	link	false	/test pull-integration-copr-test
pull-e2e-test	e494cc5	link	false	/test pull-e2e-test
pull-integration-mysql-test	e494cc5	link	false	/test pull-integration-mysql-test
pull-integration-ddl-test	e494cc5	link	false	/test pull-integration-ddl-test
pull-integration-common-test	e494cc5	link	false	/test pull-integration-common-test
pull-tiflash-test	e494cc5	link	false	/test pull-tiflash-test
pull-integration-jdbc-test	e494cc5	link	false	/test pull-integration-jdbc-test
pull-integration-binlog-test	e494cc5	link	false	/test pull-integration-binlog-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.