Skip to content

Comments

test: force to create table with "clustered" for index lookup push down tests#65167

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
lcwangchao:refine_idxpushdown_test
Dec 23, 2025
Merged

test: force to create table with "clustered" for index lookup push down tests#65167
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
lcwangchao:refine_idxpushdown_test

Conversation

@lcwangchao
Copy link
Collaborator

@lcwangchao lcwangchao commented Dec 22, 2025

What problem does this PR solve?

Issue Number: ref #62575

Problem Summary:

In integration tests, tidb_enable_clustered_index is INT_ONLY and may cause some tests does not cover common handle.

What changed and how does it work?

force use CLUSTERED for some tables when creating a table

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 22, 2025
@lcwangchao lcwangchao force-pushed the refine_idxpushdown_test branch from b941076 to e79db38 Compare December 22, 2025 10:11
@lcwangchao lcwangchao force-pushed the refine_idxpushdown_test branch from e79db38 to 69cc398 Compare December 22, 2025 10:23
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 22, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, ekexium

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 22, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 22, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-22 10:25:51.380367252 +0000 UTC m=+2073496.194144814: ☑️ agreed by cfzjywxk.
  • 2025-12-22 10:27:10.177993788 +0000 UTC m=+2073574.991771370: ☑️ agreed by ekexium.

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.6921%. Comparing base (ce06e5d) to head (69cc398).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #65167        +/-   ##
================================================
- Coverage   70.7518%   68.6921%   -2.0598%     
================================================
  Files          1895       1873        -22     
  Lines        518098     510479      -7619     
================================================
- Hits         366564     350659     -15905     
- Misses       126999     137490     +10491     
+ Partials      24535      22330      -2205     
Flag Coverage Δ
integration 41.7588% <ø> (-6.4113%) ⬇️
unit 65.9740% <ø> (+0.4532%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 38.4741% <ø> (-19.7520%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lcwangchao
Copy link
Collaborator Author

/retest

3 similar comments
@lcwangchao
Copy link
Collaborator Author

/retest

@lcwangchao
Copy link
Collaborator Author

/retest

@cfzjywxk
Copy link
Contributor

/retest

@lcwangchao lcwangchao changed the title test: set tidb_enable_clustered_index to ON for index lookup push down tests test: force to create table with "clustered" for index lookup push down tests Dec 22, 2025
@lcwangchao
Copy link
Collaborator Author

/retest

1 similar comment
@lcwangchao
Copy link
Collaborator Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 9aa2287 into pingcap:master Dec 23, 2025
29 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 23, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #65172.
But this PR has conflicts, please resolve them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants