ddl: refine active-active corner cases | tidb-test=feature/active-active by xhebox · Pull Request #65827 · pingcap/tidb

xhebox · 2026-01-27T04:14:38Z

show create table should append partdef after TTL and softdelete/active-active
build active-active/softdelete columns earlier for user defined indexes
_tidb_origin_ts should be unsigned
allow user define softdelete column but still forbidden when softdelete info != null

What problem does this PR solve?

Issue Number: close #64281

Problem Summary:

show create table should append partdef after TTL and
softdelete/active-active
build active-active/softdelete columns earlier for user defined
indexes
_tidb_origin_ts should be unsigned
allow user define softdelete column but still forbidden when
softdelete info != null

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

1. show create table should append partdef after TTL and softdelete/active-active 2. build active-active/softdelete columns earlier for user defined indexes 3. _tidb_origin_ts should be unsigned 4. allow user define softdelete column but still forbidden when softdelete info != null Signed-off-by: xhe <xw897002528@gmail.com>

tiprow · 2026-01-27T04:14:54Z

Hi @xhebox. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2026-01-27T04:35:02Z

Codecov Report

❌ Patch coverage is 77.87611% with 25 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feature/active-active@a1a16a7). Learn more about missing BASE report.

Additional details and impacted files

@@                    Coverage Diff                     @@
##             feature/active-active     #65827   +/-   ##
==========================================================
  Coverage                         ?   71.8595%           
==========================================================
  Files                            ?       1851           
  Lines                            ?     503020           
  Branches                         ?          0           
==========================================================
  Hits                             ?     361468           
  Misses                           ?     117349           
  Partials                         ?      24203

Flag	Coverage Δ
integration	`48.4508% <77.8761%> (?)`
unit	`65.6261% <54.8672%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.8700% <0.0000%> (?)`
parser	`∅ <0.0000%> (?)`
br	`60.4112% <0.0000%> (?)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pkg/ddl/create_table.go

pkg/meta/model/column.go

lcwangchao

rest LGTM

Signed-off-by: xhe <xw897002528@gmail.com>

lcwangchao · 2026-01-28T12:11:35Z

pkg/ddl/create_table.go

+			// User-defined internal column must match expected type.
+			expected := model.NewExtraSoftDeleteTimeColInfo().FieldType
+			col := model.FindColumnInfo(tbInfo.Columns, model.ExtraSoftDeleteTimeName.L)
+			if col.FieldType.GetType() != expected.GetType() || col.FieldType.GetFlen() != expected.GetFlen() || col.FieldType.GetDecimal() != expected.GetDecimal() {


To apply checkInternalColumnFieldTypeMatch here?

lcwangchao

Rest LGTM

xhebox · 2026-01-28T15:12:35Z

/retest

tiprow · 2026-01-28T15:13:00Z

@xhebox: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: xhe <xw897002528@gmail.com>

xhebox · 2026-01-29T02:59:45Z

/retest

tiprow · 2026-01-29T03:00:08Z

@xhebox: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

xhebox · 2026-01-29T03:00:20Z

/ok-to-test

Signed-off-by: xhe <xw897002528@gmail.com>

xhebox · 2026-01-29T05:26:57Z

/retest

YangKeao

LGTM

ti-chi-bot · 2026-01-29T05:28:56Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lcwangchao, YangKeao
Once this PR has been reviewed and has the lgtm label, please assign d3hunter for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [YangKeao,lcwangchao]
pkg/ddl/OWNERS
pkg/meta/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2026-01-29T05:29:00Z

[LGTM Timeline notifier]

Timeline:

2026-01-28 12:42:06.451397438 +0000 UTC m=+1188954.065354284: ☑️ agreed by lcwangchao.
2026-01-29 05:28:59.15305833 +0000 UTC m=+1249366.767015176: ☑️ agreed by YangKeao.

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 27, 2026

lcwangchao reviewed Jan 27, 2026

View reviewed changes

pkg/ddl/create_table.go Outdated Show resolved Hide resolved

lcwangchao reviewed Jan 27, 2026

View reviewed changes

pkg/meta/model/column.go Show resolved Hide resolved

lcwangchao reviewed Jan 27, 2026

View reviewed changes

pkg/meta/model/column.go Show resolved Hide resolved

lcwangchao reviewed Jan 27, 2026

View reviewed changes

fix

cf7dbb3

Signed-off-by: xhe <xw897002528@gmail.com>

lcwangchao reviewed Jan 28, 2026

View reviewed changes

lcwangchao approved these changes Jan 28, 2026

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 28, 2026

lcwangchao changed the title ~~ddl: refine active-active corner cases | tidb-test=feature/active-active tikv=feature/active-active~~ ddl: refine active-active corner cases | tidb-test=feature/active-active Jan 28, 2026

fix

302b8fa

Signed-off-by: xhe <xw897002528@gmail.com>

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jan 29, 2026

fix

ef8bfa6

Signed-off-by: xhe <xw897002528@gmail.com>

YangKeao approved these changes Jan 29, 2026

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 29, 2026

ti-chi-bot added the approved label Jan 29, 2026

ti-chi-bot bot merged commit f687417 into pingcap:feature/active-active Jan 29, 2026
24 checks passed

Conversation

xhebox commented Jan 27, 2026

What problem does this PR solve?

Check List

Release note

Uh oh!

tiprow bot commented Jan 27, 2026

Uh oh!

codecov bot commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lcwangchao left a comment

Choose a reason for hiding this comment

Uh oh!

lcwangchao Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

lcwangchao left a comment

Choose a reason for hiding this comment

Uh oh!

xhebox commented Jan 28, 2026

Uh oh!

tiprow bot commented Jan 28, 2026

Uh oh!

xhebox commented Jan 29, 2026

Uh oh!

tiprow bot commented Jan 29, 2026

Uh oh!

xhebox commented Jan 29, 2026

Uh oh!

xhebox commented Jan 29, 2026

Uh oh!

YangKeao left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Jan 29, 2026

Uh oh!

ti-chi-bot bot commented Jan 29, 2026

[LGTM Timeline notifier]

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jan 27, 2026 •

edited

Loading