sessiontxn: reject AS OF TIMESTAMP when autocommit is disabled #65960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
|
/retest |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #65960 +/- ##
================================================
- Coverage 77.7751% 77.6046% -0.1705%
================================================
Files 2001 1923 -78
Lines 545618 533201 -12417
================================================
- Hits 424355 413789 -10566
+ Misses 119601 119406 -195
+ Partials 1662 6 -1656
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
wfxr
force-pushed
the
stale-read/65957
branch
from
a0998ed to
f58b7fe
Compare
Member
Author
|
/retest |
According to the Stale Read product design, `SELECT ... AS OF TIMESTAMP` should only be used in implicit transactions with autocommit=1. However, it was possible to execute such statements even when autocommit=0. This change adds a check for `!IsAutocommit()` in `OnSelectTable` and `OnExecutePreparedStmt` methods to properly reject AS OF TIMESTAMP queries when autocommit is disabled. Close pingcap#65957
… change Update the expected result to expect error 8135 when executing AS OF TIMESTAMP query with autocommit disabled, matching the behavior change in commit f58b7fe.
wfxr
force-pushed
the
stale-read/65957
branch
from
54b1959 to
53a659e
Compare
Member
Author
|
/retest |
12 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #65957
Problem Summary:
According to the Stale Read product design,
SELECT ... AS OF TIMESTAMPshould only be used in implicit transactions withautocommit=1. However, it was possible to execute such statements even whenautocommit=0.What changed and how does it work?
This change adds a check for
!IsAutocommit()inOnSelectTableandOnExecutePreparedStmtmethods inpkg/sessiontxn/staleread/processor.goto properly rejectAS OF TIMESTAMPqueries when autocommit is disabled.The error message is also updated from:
to:
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.