Skip to content

docs: replace deprecated PingCAP domains#67522

Open
wuhuizuo wants to merge 2 commits into
masterfrom
fix/update-pingcap-domains-master
Open

docs: replace deprecated PingCAP domains#67522
wuhuizuo wants to merge 2 commits into
masterfrom
fix/update-pingcap-domains-master

Conversation

@wuhuizuo
Copy link
Copy Markdown
Contributor

@wuhuizuo wuhuizuo commented Apr 2, 2026

What problem does this PR solve?

Issue Number: close #67527

Problem Summary:

download.pingcap.org is being deprecated in favor of download.pingcap.com, but TiDB still has old-domain references in Dumpling install/docs and BR test download helpers on master.

What changed and how does it work?

  • replace deprecated download.pingcap.org references with download.pingcap.com in br/tests/download_tools.sh, dumpling/README.md, and dumpling/install.sh
  • keep existing paths and current master behavior unchanged

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Manual test steps:

  • git diff --check
  • verify no remaining old-domain references in br/tests/download_tools.sh, dumpling/README.md, and dumpling/install.sh
  • curl -I https://download.pingcap.com/tiflash-nightly-linux-amd64.tar.gz
  • curl -I https://download.pingcap.com/tidb-nightly-linux-amd64.tar.gz
  • curl -I https://download.pingcap.com/ticdc-nightly-linux-amd64.tar.gz
  • curl -I http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz
  • curl -I https://download.pingcap.com/tidb-master-linux-amd64.tar.gz
  • curl -I https://download.pingcap.com/tidb-toolkit-latest-linux-amd64.tar.gz
  • curl -I http://download.pingcap.com/tidb-toolkit-nightly-linux-amd64.tar.gz
  • linked tracking issue #67527 is labeled type/compatibility

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

none

@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 2, 2026
@pantheon-ai
Copy link
Copy Markdown

pantheon-ai Bot commented Apr 2, 2026

Review Complete

Findings: 0 issues
Posted: 0
Duplicates/Skipped: 0

ℹ️ Learn more details on Pantheon AI.

@ti-chi-bot ti-chi-bot Bot added component/dumpling This is related to Dumpling of TiDB. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 2, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign 3pointer, d3hunter for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tiprow
Copy link
Copy Markdown

tiprow Bot commented Apr 2, 2026

Hi @wuhuizuo. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 2, 2026

📝 Walkthrough

Walkthrough

Domain migration of download URLs for PingCAP nightly components across scripts and docs: download.pingcap.orgdownload.pingcap.com. No other logic or control flow changes.

Changes

Cohort / File(s) Summary
BR download script
br/tests/download_tools.sh
Replaced download domain from download.pingcap.org to download.pingcap.com for Tiflash, TiDB nightly bundle, and TiCDC; download/extract/move steps unchanged.
Dumpling installer
dumpling/install.sh
Switched toolkit download URL domain to download.pingcap.com; output filename and extraction logic unchanged.
Dumpling README
dumpling/README.md
Updated example/download URLs to download.pingcap.com for sync_diff_inspector, tidb-server, and tidb-lightning; removed trailing newline.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A Rabbit's Download Hop
From .org to .com I leap,
Gentle bytes no longer sleep,
Same carrots, new burrowed trail,
Fetch and extract — hop, don't fail! 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description follows the repository template and includes all required sections: issue number linked to #67527, problem summary explaining the deprecation, changes and how they work, and a complete checklist with manual test steps.
Title check ✅ Passed The title clearly and accurately summarizes the main change: replacing deprecated PingCAP domains across multiple files (download.pingcap.org → download.pingcap.com).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/update-pingcap-domains-master

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@dumpling/README.md`:
- Around line 32-34: Update the download URL for `bin/sync_diff_inspector` in
the README so it uses HTTPS instead of HTTP: replace
`http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz`
with
`https://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz`
to match the other entries (`bin/tidb-server`, `bin/tidb-lightning`) and avoid
the HTTP->HTTPS redirect.
🪄 Autofix (Beta)

✅ Autofix completed


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 20910d86-9f5e-43c5-a765-0ae2c7c51abf

📥 Commits

Reviewing files that changed from the base of the PR and between 4d20c4a and 2caf375.

📒 Files selected for processing (3)
  • br/tests/download_tools.sh
  • dumpling/README.md
  • dumpling/install.sh

Comment thread dumpling/README.md Outdated
Copy link
Copy Markdown

@pantheon-ai pantheon-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code looks good. No issues found.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 2, 2026

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Fixes Applied Successfully

Fixed 1 file(s) based on 1 unresolved review comment.

Files modified:

  • dumpling/README.md

Commit: 6d24f8e1b56e458aff2faef581a96db3183c2371

The changes have been pushed to the fix/update-pingcap-domains-master branch.

Time taken: 1m 46s

Fixed 1 file(s) based on 1 unresolved review comment.

Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-triage-completed labels Apr 2, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.7924%. Comparing base (4d20c4a) to head (6d24f8e).
⚠️ Report is 161 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #67522        +/-   ##
================================================
+ Coverage   77.7474%   78.7924%   +1.0449%     
================================================
  Files          1959       1960         +1     
  Lines        543377     543542       +165     
================================================
+ Hits         422462     428270      +5808     
+ Misses       120074     114247      -5827     
- Partials        841       1025       +184     
Flag Coverage Δ
integration 44.4357% <ø> (+8.2610%) ⬆️
unit 76.7348% <ø> (+0.3497%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 61.5065% <ø> (ø)
parser ∅ <ø> (∅)
br 66.2966% <ø> (+5.2801%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wuhuizuo
Copy link
Copy Markdown
Contributor Author

wuhuizuo commented Apr 7, 2026

/retest

@tiprow
Copy link
Copy Markdown

tiprow Bot commented Apr 7, 2026

@wuhuizuo: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wuhuizuo wuhuizuo changed the title docs: replace deprecated PingCAP domains docs: replace deprecated PingCAP domains | pd=@master_linux_amd64 May 6, 2026
@wuhuizuo
Copy link
Copy Markdown
Contributor Author

wuhuizuo commented May 6, 2026

/test ?

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 6, 2026

@wuhuizuo: The following commands are available to trigger required jobs:

/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-build-next-gen
/test pull-integration-e2e-test
/test pull-integration-realcluster-test-next-gen
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-mysql-client-test-next-gen
/test pull-unit-test-ddlv1
/test pull-unit-test-next-gen
/test unit-test

The following commands are available to trigger optional jobs:

/test pingcap/tidb/canary_ghpr_unit_test
/test pull-br-integration-test-next-gen
/test pull-check-deps
/test pull-common-test
/test pull-e2e-test
/test pull-error-log-review
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-ddl-test
/test pull-integration-ddl-test-next-gen
/test pull-integration-e2e-test-next-gen
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-mysql-test-next-gen
/test pull-sqllogic-test
/test pull-tiflash-integration-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_br_integration_test
pingcap/tidb/pull_build_next_gen
pingcap/tidb/pull_integration_e2e_test
pingcap/tidb/pull_integration_realcluster_test_next_gen
pingcap/tidb/pull_mysql_client_test
pingcap/tidb/pull_mysql_client_test_next_gen
pingcap/tidb/pull_unit_test_next_gen
pull-check-deps
pull-error-log-review
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wuhuizuo
Copy link
Copy Markdown
Contributor Author

wuhuizuo commented May 6, 2026

/test check-dev2

@pingcap pingcap deleted a comment from tiprow Bot May 6, 2026
@pingcap pingcap deleted a comment from tiprow Bot May 6, 2026
@ti-chi-bot ti-chi-bot changed the title docs: replace deprecated PingCAP domains | pd=@master_linux_amd64 docs: replace deprecated PingCAP domains May 8, 2026
@wuhuizuo wuhuizuo changed the title docs: replace deprecated PingCAP domains docs: replace deprecated PingCAP domains | May 8, 2026
@wuhuizuo wuhuizuo changed the title docs: replace deprecated PingCAP domains | docs: replace deprecated PingCAP domains May 8, 2026
@wuhuizuo
Copy link
Copy Markdown
Contributor Author

wuhuizuo commented May 8, 2026

/retest

@tiprow
Copy link
Copy Markdown

tiprow Bot commented May 8, 2026

@wuhuizuo: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 8, 2026

@wuhuizuo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 6d24f8e link true /test check-dev2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/dumpling This is related to Dumpling of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace deprecated PingCAP download domains in TiDB scripts and docs

1 participant