build(deps): bump client-go to include pd#10522 (#67491)#67602
Conversation
Signed-off-by: okjiang <819421878@qq.com>
Signed-off-by: okjiang <819421878@qq.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdates pinned versions of two TiKV-related Go modules: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, okJiang, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-nextgen-202603 #67602 +/- ##
===========================================================
Coverage ? 77.5430%
===========================================================
Files ? 1960
Lines ? 543381
Branches ? 0
===========================================================
Hits ? 421354
Misses ? 121175
Partials ? 852
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/retest |
9 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
4fe6bb3
into
pingcap:release-nextgen-202603
This is an automated cherry-pick of #67491
What problem does this PR solve?
Issue Number: ref #67511,
ref tikv/pd#10522, ref tikv/client-go#1935
Problem Summary:
TiDB should consume the merged upstream
client-gochange that includes the RM fallback warning-spam fix fromtikv/pd#10522.What changed and how does it work?
github.com/tikv/client-go/v2tov2.0.8-0.20260401083018-b7f9a9e9d2ab, which is the merged upstream commit fromtikv/client-go#1935github.com/tikv/pd/clientversion atv0.0.0-20260401072359-048f0d8f6f71DEPS.bzlso Bazel fetches the upstreamclient-goartifact instead of the temporary fork artifact used earlier in this PRCheck List
Tests
Manual test steps:
go mod tidymake bazel_preparego test -run TestNonExistent ./br/pkg/... ./lightning/pkg/... ./dumpling/exportgo list ./cmd/tidb-server ./pkg/store/... ./pkg/server/... ./pkg/session/... ./pkg/executor/... ./pkg/planner/... | rg -v '/test/|/tests/|_test$|^github.com/pingcap/tidb/pkg/planner/implementation$' | xargs -n 40 go test -run TestNonExistentSide effects
Documentation
Release note
Summary by CodeRabbit