Skip to content

build(deps): bump client-go to include pd#10522 (#67491)#67602

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-nextgen-202603from
ti-chi-bot:cherry-pick-67491-to-release-nextgen-202603
Apr 9, 2026
Merged

build(deps): bump client-go to include pd#10522 (#67491)#67602
ti-chi-bot[bot] merged 2 commits intopingcap:release-nextgen-202603from
ti-chi-bot:cherry-pick-67491-to-release-nextgen-202603

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

@ti-chi-bot ti-chi-bot commented Apr 8, 2026

This is an automated cherry-pick of #67491

What problem does this PR solve?

Issue Number: ref #67511,

ref tikv/pd#10522, ref tikv/client-go#1935

Problem Summary:
TiDB should consume the merged upstream client-go change that includes the RM fallback warning-spam fix from tikv/pd#10522.

What changed and how does it work?

  • bump github.com/tikv/client-go/v2 to v2.0.8-0.20260401083018-b7f9a9e9d2ab, which is the merged upstream commit from tikv/client-go#1935
  • keep the resolved github.com/tikv/pd/client version at v0.0.0-20260401072359-048f0d8f6f71
  • refresh DEPS.bzl so Bazel fetches the upstream client-go artifact instead of the temporary fork artifact used earlier in this PR

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Manual test steps:

  • go mod tidy
  • make bazel_prepare
  • go test -run TestNonExistent ./br/pkg/... ./lightning/pkg/... ./dumpling/export
  • go list ./cmd/tidb-server ./pkg/store/... ./pkg/server/... ./pkg/session/... ./pkg/executor/... ./pkg/planner/... | rg -v '/test/|/tests/|_test$|^github.com/pingcap/tidb/pkg/planner/implementation$' | xargs -n 40 go test -run TestNonExistent

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Summary by CodeRabbit

  • Chores
    • Updated internal Go dependencies to newer versions.

okJiang added 2 commits April 8, 2026 03:50
Signed-off-by: okjiang <819421878@qq.com>
Signed-off-by: okjiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-nextgen-202603 labels Apr 8, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: dfec072b-ec74-4bb7-9199-225a650a9fb4

📥 Commits

Reviewing files that changed from the base of the PR and between 057c2ad and f68990a.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • DEPS.bzl
  • go.mod

📝 Walkthrough

Walkthrough

Updates pinned versions of two TiKV-related Go modules: github.com/tikv/client-go/v2 and github.com/tikv/pd/client in both DEPS.bzl (Bazel build configuration with checksums and archives) and go.mod (Go module dependency specifications).

Changes

Cohort / File(s) Summary
Bazel Dependencies
DEPS.bzl
Updated sha256, strip_prefix, and urls entries for both TiKV client-go and pd/client go_repository declarations to reference newer upstream archives.
Go Module Versions
go.mod
Bumped version pins in require statements for github.com/tikv/client-go/v2 and github.com/tikv/pd/client to newer pseudo-versions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

Possibly related PRs

Suggested labels

cherry-pick-approved, ok-to-test, approved, lgtm

Suggested reviewers

  • lhy1024
  • YuJuncen
  • bb7133

Poem

🐰 Dependencies dance and versions bump,
Client-go and pd leap with thump!
Bazel checksums tick, modules align,
TiKV paths now point so fine! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: bumping client-go to include a specific upstream fix (pd#10522), matching the primary objective of consuming an upstream dependency change.
Description check ✅ Passed The description follows the required template structure with all critical sections completed: issue references, problem summary, detailed explanation of changes, test checklist with selections, and release note. Manual test steps are provided.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 8, 2026
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 8, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 8, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-04-08 03:51:16.772797928 +0000 UTC m=+928281.978157985: ☑️ agreed by okJiang.
  • 2026-04-08 03:55:45.363374634 +0000 UTC m=+928550.568734701: ☑️ agreed by rleungx.

@okJiang
Copy link
Copy Markdown
Member

okJiang commented Apr 8, 2026

/retest

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 8, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cfzjywxk,okJiang,rleungx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Apr 8, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-nextgen-202603@057c2ad). Learn more about missing BASE report.

Additional details and impacted files
@@                     Coverage Diff                     @@
##             release-nextgen-202603     #67602   +/-   ##
===========================================================
  Coverage                          ?   77.5430%           
===========================================================
  Files                             ?       1960           
  Lines                             ?     543381           
  Branches                          ?          0           
===========================================================
  Hits                              ?     421354           
  Misses                            ?     121175           
  Partials                          ?        852           
Flag Coverage Δ
unit 76.1455% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 61.5065% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 60.9645% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@okJiang
Copy link
Copy Markdown
Member

okJiang commented Apr 8, 2026

/retest

9 similar comments
@okJiang
Copy link
Copy Markdown
Member

okJiang commented Apr 8, 2026

/retest

@okJiang
Copy link
Copy Markdown
Member

okJiang commented Apr 8, 2026

/retest

@okJiang
Copy link
Copy Markdown
Member

okJiang commented Apr 8, 2026

/retest

@rleungx
Copy link
Copy Markdown
Member

rleungx commented Apr 8, 2026

/retest

@hawkingrei
Copy link
Copy Markdown
Member

/retest

@hawkingrei
Copy link
Copy Markdown
Member

/retest

@hawkingrei
Copy link
Copy Markdown
Member

/retest

@hawkingrei
Copy link
Copy Markdown
Member

/retest

@okJiang
Copy link
Copy Markdown
Member

okJiang commented Apr 9, 2026

/retest

@ti-chi-bot ti-chi-bot Bot merged commit 4fe6bb3 into pingcap:release-nextgen-202603 Apr 9, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-nextgen-202603

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants