config: bump client-go and increase default RUScale from 1.34 to 2.01 by disksing · Pull Request #68217 · pingcap/tidb

disksing · 2026-05-08T06:10:24Z

What problem does this PR solve?

Issue Number: ref #67199

Problem Summary:
Cherry-pick #68000 to release-nextgen-202603.

What changed and how does it work?

Bump github.com/tikv/client-go/v2 to the latest commit (fce9638195b3684c19dfe35186f2ceed480e8a9e).
Increase TiDB-side default RUScale from 1.34 to 2.01 (multiply by 1.5).
Update config.toml.example TiKV-side ru-scale from 1.40 to 2.10 to match the new client-go default.
Update related unit test expectations in pkg/util/execdetails.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Summary by CodeRabbit

Chores
- Updated TiKV client and PD client dependencies and bumped several Go stdlib modules.
Bug Fixes
- Increased default RU v2 scaling factor from 1.34 to 2.01 to correct resource-unit calculations and examples.
Tests
- Updated test expectations and examples to reflect new RU v2 scaling and resulting metric values.

ti-chi-bot · 2026-05-08T06:10:35Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cfzjywxk, terry1purcell for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS
pkg/config/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tiprow · 2026-05-08T06:10:41Z

Hi @disksing. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

coderabbitai · 2026-05-08T06:10:47Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 53139f79-538e-44d1-9634-3f7ec0efe4c4

📥 Commits

Reviewing files that changed from the base of the PR and between f1350d4 and ac7010d.

⛔ Files ignored due to path filters (1)

go.sum is excluded by !**/*.sum

📒 Files selected for processing (6)

DEPS.bzl
go.mod
pkg/config/config.go
pkg/config/config.toml.example
pkg/config/config_test.go
pkg/util/execdetails/execdetails_test.go

🚧 Files skipped from review as they are similar to previous changes (6)

pkg/config/config.toml.example
pkg/config/config.go
go.mod
pkg/util/execdetails/execdetails_test.go
pkg/config/config_test.go
DEPS.bzl

📝 Walkthrough

Walkthrough

Bumps TiKV client-go and several golang.org/x/* dependencies in DEPS.bzl and go.mod. Increases RU v2 default RUScale from 1.34 to 2.01 and updates example config and test expectations to match recalculated RU totals and formatted metrics.

Changes

TiKV Client and RU v2 Configuration Update

Layer / File(s)	Summary
Dependency Updates `DEPS.bzl`, `go.mod`	Bump `github.com/tikv/client-go/v2` and `github.com/tikv/pd/client` to newer commits; advance multiple `golang.org/x/*` modules and indirect telemetry/crypto entries.
RU v2 Configuration Default `pkg/config/config.go`	`DefaultRUV2Config()` changes `RUV2Config.RUScale` default from `1.34` to `2.01`.
Example Configuration `pkg/config/config.toml.example`	`ru-scale` updated in `[ru-v2]` and `[tikv-client.ru-v2]` to reflect new scaling factors.
Test Expectations `pkg/config/config_test.go`, `pkg/util/execdetails/execdetails_test.go`	Updated assertions: `TestConfig` expects `RUScale` == `2.01`; `TestRUV2MetricsSnapshotCalculateRUValues` expects new `totalRU`; `TestFormatRUV2MetricsIncludesRUValuesFirst` expects formatted totals including `total_ru:11236.09` and `tidb_ru:3.09`.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

pingcap/tidb#68000: Similar TiKV client-go dependency bump and RU v2 scale/test updates.
pingcap/tidb#67491: Related dependency pin updates for TikV client/pd in DEPS.bzl and go.mod.
pingcap/tidb#67320: Prior PR that updated TiKV client pin and changed RU v2 default.

Suggested labels

size/M, ok-to-test, type/cherry-pick-for-release-nextgen-202603

Suggested reviewers

cfzjywxk
yudongusa
JmPotato

Poem

🐰 I hopped through deps with nimble paws,
Bumped client-go and checked the laws,
RUScale climbed up to two point oh one,
Tests and configs tuned — the long race done,
A tiny hop; a steady run.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the two main changes: bumping client-go dependency and increasing the default RUScale value from 1.34 to 2.01.
Description check	✅ Passed	The description includes all required sections with adequate detail: issue reference, clear explanation of changes, completed checklist with unit tests marked, and release note section.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

Generate code and open pull requests
Plan features and break down work
Investigate incidents and troubleshoot customer tickets together
Automate recurring tasks and respond to alerts with triggers
Summarize progress and report instantly

Built for teams:

Shared memory across your entire org—no repeating context
Per-thread sandboxes to safely plan and execute work
Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

- Update github.com/tikv/client-go/v2 to latest version (fce9638). - Increase TiDB-side default RUScale from 1.34 to 2.01 (1.5x). - Sync TiKV-side ru-scale in config.toml.example from 1.40 to 2.10. - Update related test expectations. Signed-off-by: disksing <i@disksing.com>

disksing · 2026-05-08T07:41:30Z

/retest

tiprow · 2026-05-08T07:41:55Z

@disksing: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

disksing · 2026-05-08T09:44:50Z

/ok-to-test

disksing · 2026-05-09T03:25:10Z

/retest

disksing · 2026-05-09T08:36:33Z

/retest

ti-chi-bot · 2026-05-09T09:32:07Z

@disksing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-integration-realcluster-test-next-gen	`ac7010d`	link	true	`/test pull-integration-realcluster-test-next-gen`
pull-unit-test-next-gen	`ac7010d`	link	true	`/test pull-unit-test-next-gen`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 8, 2026

disksing force-pushed the cherry-pick-68000-to-release-nextgen-202603 branch from f1350d4 to ac7010d Compare May 8, 2026 06:22

ti-chi-bot Bot added the ok-to-test Indicates a PR is ready to be tested. label May 8, 2026

Conversation

disksing commented May 8, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Summary by CodeRabbit

Uh oh!

ti-chi-bot Bot commented May 8, 2026

Uh oh!

tiprow Bot commented May 8, 2026

Uh oh!

coderabbitai Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

disksing commented May 8, 2026

Uh oh!

tiprow Bot commented May 8, 2026

Uh oh!

disksing commented May 8, 2026

Uh oh!

disksing commented May 9, 2026

Uh oh!

disksing commented May 9, 2026

Uh oh!

ti-chi-bot Bot commented May 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

disksing commented May 8, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 8, 2026 •

edited

Loading