Switch checks to use retool. Fix goword and errcheck

[gregwebs]

What have you changed? (mandatory)

Switch checks to use retool. retool vendors check tools local to the project.
Note that you can also add other tools such as code generators to the retool setup.

Fix goword and errcheck: these were not being run correctly.These are now under the check-fail task.

I would recommend creating an issue to fix the check-fail task. This can be time boxed to some amount of time per week, but will probably take more than one day total. errcheck in particular is of great importance: unhandled errors are almost guaranteed to result in bugs. I can show you how I handle collecting errors in defer statements.

What is the type of the changes? (mandatory)

Improvement/New Feature for static analysis

How has this PR been tested? (mandatory)

make check

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

no

Does this PR affect tidb-ansible update? (mandatory)

no

Does this PR need to be added to the release notes? (mandatory)

Switch static checks to use retool.

[zz-jason]

CI failed by:

retool: downloading honnef.co/go/tools/cmd/megacheck
retool: fatal err: execution error on "go get -d honnef.co/go/tools/cmd/megacheck": package honnef.co/go/tools/cmd/megacheck: unrecognized import path "honnef.co/go/tools/cmd/megacheck" (parse https://honnef.co/go/tools/cmd/megacheck?go-get=1: no go-import meta tags ())
: failed to 'go get' tool: exit status 1
Makefile:103: recipe for target 'check-setup' failed

[gregwebs]

That's odd: this is the same as PD which is building just fine. Let me know if you understand this error. Otherwise I will just remove it for now: there are plenty of other checks to deal with right now.
https://github.com/pingcap/pd/blob/master/tools.json
https://github.com/pingcap/pd/blob/master/Makefile#L54

[lysu]

It seems honnef.co unreachable at that moment, so go get couldn't get meta to redirect to git?? I have rerun it and seems to be ok now.

[zz-jason]

s/checking/check/?

[zz-jason]

Could you file a github issue for these failed checks? Maybe we can make these checks happy again with the help of the community. 😄

[zz-jason]

Should we add tol-install into this section?

[gregwebs]

retool sync installs everything from tools.json. tool-install is the record of how that was generated. Its probably better to put tool-install into a hack/scripts/config folder rather than clutter the Makefile.

[zz-jason]

LGTM

[zz-jason]

@shenli @coocood PTAL

[ngaut]

LGTM. Close #7247

[gregwebs]

#7247 was opened as requested by @zz-jason