Skip to content

tici: Update tici and pass read_tso to tici - #10362

Merged
ti-chi-bot[bot] merged 3 commits into
pingcap:feature/ftsfrom
JinheLin:fts_read_tso
Aug 25, 2025
Merged

tici: Update tici and pass read_tso to tici#10362
ti-chi-bot[bot] merged 3 commits into
pingcap:feature/ftsfrom
JinheLin:fts_read_tso

Conversation

@JinheLin

@JinheLin JinheLin commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

read_tso in log:
[2025-08-25T05:31:48Z INFO tici_search_lib] Search t_124/i_2/s_1, query: Expr { tp: 10000, val: "", children: [Expr { tp: 5, val: "info", children: [], rpn_args_len: 139977282944196, sig: 3800264, field_type: 32591 }, Expr { tp: 201, val: "column_3", children: [], rpn_args_len: 8, sig: 42291232, field_type: 32593 }], rpn_args_len: 3199092244751596146, sig: 5201, field_type: 979463525 }, read_ts: 460351054397833223, return_fields: ["column_3", "column_4", "column_5", "column_1"], ranges: [[74800000000000007c, 74800000000000007d)], param: SearchParam { topK: 0 }, docs: 13042, elapsed: 15ms, search_stat: ShardReaderStat { range_disjoint_frag_count: 0, range_subset_frag_count: 1, range_overlap_frag_count: 0, match_doc_count: 13042, range_filter_doc_count: 0 }


Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 25, 2025
@JinheLin JinheLin changed the title tici: Update tici and pass read_tso to tici WIP: tici: Update tici and pass read_tso to tici Aug 25, 2025
@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2025
@JinheLin JinheLin changed the title WIP: tici: Update tici and pass read_tso to tici tici: Update tici and pass read_tso to tici Aug 25, 2025
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2025
@ti-chi-bot ti-chi-bot Bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 25, 2025
@JinheLin

Copy link
Copy Markdown
Contributor Author

/retest

@CalvinNeo CalvinNeo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot Bot added the lgtm label Aug 25, 2025
@ti-chi-bot

ti-chi-bot Bot commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 25, 2025
@ti-chi-bot

ti-chi-bot Bot commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

[LGTM Timeline notifier]

Timeline:

  • 2025-08-25 07:08:15.797646256 +0000 UTC m=+164787.675477211: ☑️ agreed by Lloyd-Pottiger.
  • 2025-08-25 09:19:05.006861483 +0000 UTC m=+172636.884692437: ☑️ agreed by CalvinNeo.

@ti-chi-bot
ti-chi-bot Bot merged commit 4404720 into pingcap:feature/fts Aug 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants