Fix report status error#10972
Conversation
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis change fixes a crash where reporting MPP task status failed when local RU consumption was not initialized. RU consumption info is now synced into ExecutorStatisticsCollector before generating execution responses, and ChangesRU Consumption Sync Fix
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant MPPTask
participant MPPTaskStatistics
participant ExecutorStatisticsCollector
MPPTask->>MPPTaskStatistics: genTiFlashExecutionInfo()/genExecutionSummaryResponse()
MPPTaskStatistics->>MPPTaskStatistics: syncRUInfoToExecutorStatisticsCollector()
MPPTaskStatistics->>ExecutorStatisticsCollector: setLocalRUConsumption(ru_info)
ExecutorStatisticsCollector->>ExecutorStatisticsCollector: emplace or Clear local_ru
ExecutorStatisticsCollector-->>MPPTask: execution response with RU consumption
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gengliqi, xzhangxian1008 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/test pull-unit-test |
What problem does this PR solve?
Issue Number: close #10962
Problem Summary:
port #10963 to master branch
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Summary by CodeRabbit
Bug Fixes
Tests