Skip to content

*: replace NOTICE with ThirdPartyNotices.txt - #11061

Draft
dillon-zheng wants to merge 2 commits into
pingcap:masterfrom
dillon-zheng:update-third-party-notices
Draft

*: replace NOTICE with ThirdPartyNotices.txt#11061
dillon-zheng wants to merge 2 commits into
pingcap:masterfrom
dillon-zheng:update-third-party-notices

Conversation

@dillon-zheng

Copy link
Copy Markdown

What problem does this PR solve?

Issue Number: N/A (draft documentation/compliance artifact)

The root NOTICE was last updated in 2022 and no longer represented the
current C/C++ source inputs. It also used a different name from the
ThirdPartyNotices.txt convention used by the other notice updates.

What is changed and how it works?

Replaces root NOTICE with a self-contained root ThirdPartyNotices.txt.

  • Records the current gitlink revision and pinned source/license URLs for 45
    public third-party contrib/ submodules.
  • Covers 60 C/C++ source components with 64 unique reproduced license or
    upstream-NOTICE texts, including the AWS CRT components, gRPC, BoringSSL's
    fiat code, and QPL's ISA-L code.
  • Adds the directly vendored C/C++ source inputs and retains their local
    license evidence.
  • States the source-only scope and exclusions: Rust/Cargo, first-party and
    private submodules, system/toolchain libraries, container images, and package
    inputs require release-target-specific notice assembly.
  • Updates .github/licenserc.yml for the replacement filename.
*: replace NOTICE with third-party notices

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • Verified all 45 scoped public third-party submodules match the gitlink
      revision recorded in the notice.
    • Retrieved each GitHub license/NOTICE evidence file at its exact revision.
    • Verified 60 component records and 64 balanced license/notice text blocks.
    • git diff --check
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: weizheng <wei.zheng@pingcap.com>
@ti-chi-bot

ti-chi-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 27, 2026
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 27, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ichn-hu for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pingcap-cla-assistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Signed-off-by: weizheng <wei.zheng@pingcap.com>
@ti-chi-bot

ti-chi-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

@wuhuizuo

Copy link
Copy Markdown
Contributor

/test ?

@ti-chi-bot

ti-chi-bot Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

@wuhuizuo: The following commands are available to trigger required jobs:

/test pull-integration-next-gen
/test pull-integration-next-gen-columnar
/test pull-integration-test
/test pull-unit-next-gen
/test pull-unit-test

The following commands are available to trigger optional jobs:

/test pull-error-log-review
/test pull-license-check
/test pull-sanitizer-asan
/test pull-sanitizer-tsan

Use /test all to run the following jobs that were automatically triggered:

pingcap/tiflash/pull_integration_next_gen
pingcap/tiflash/pull_integration_next_gen_columnar
pingcap/tiflash/pull_integration_test
pingcap/tiflash/pull_unit_next_gen
pingcap/tiflash/pull_unit_test
pull-license-check
pull-sanitizer-asan
pull-sanitizer-tsan
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wuhuizuo

Copy link
Copy Markdown
Contributor

/test pull-license-check

ti-chi-bot Bot pushed a commit to PingCAP-QE/ci that referenced this pull request Aug 29, 2026
… check (#5053)

### Summary
`pull-license-check` on tiflash was failing because the OCI-downloaded
`license-eye` binary is glibc-dynamically-linked while the `utils` image
(oras/yq provider) has no glibc (`cannot execute: required file not
found`).

Instead of the initContainer + shared-volume glibc workaround, switch to
the official **`apache/skywalking-eyes:0.4.0`** image: it ships its own
(musl) runtime and has `license-eye` as its entrypoint, so the job is a
single container:

```yaml
containers:
  - name: main
    image: apache/skywalking-eyes:0.4.0
    args: ["-c", ".github/licenserc.yml", "header", "check"]
```

Verified on the cluster: the image pulls and `license-eye` runs
(`--version`).

### Related
Tested against pingcap/tiflash#11061.
@wuhuizuo

Copy link
Copy Markdown
Contributor

/test pull-license-check

2 similar comments
@wuhuizuo

Copy link
Copy Markdown
Contributor

/test pull-license-check

@wuhuizuo

Copy link
Copy Markdown
Contributor

/test pull-license-check

ti-chi-bot Bot pushed a commit to PingCAP-QE/ci that referenced this pull request Aug 29, 2026
…check (#5056)

### Summary
STEP 2 of consolidating the tiflash license check into the standalone
presubmit:
- Remove the `License check` stage (and the now-unused
`OCI_ARTIFACT_HOST` env in `merged_build`) from `merged_build` /
`pull_integration_test` pipelines across all tiflash branches (12 files)
- Make `pull-license-check` **required** (`optional: false`) in
`prow-jobs/pingcap/tiflash/common-presubmits.yaml`

The in-pipeline license steps were also broken anyway: the
OCI-downloaded `license-eye` is glibc-linked while the `utils` image is
glibc-less.

### Verified
- All changed Jenkins pipelines pass `.ci/verify-jenkins-pipelines.sh`
(Jenkins lint)
- `pull-license-check` presubmit validated on pingcap/tiflash#11061
(pass)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants