*: replace NOTICE with ThirdPartyNotices.txt - #11061
Conversation
Signed-off-by: weizheng <wei.zheng@pingcap.com>
|
Skipping CI for Draft Pull Request. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
Signed-off-by: weizheng <wei.zheng@pingcap.com>
|
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Contribute Code" section in the development guide. |
|
/test ? |
|
@wuhuizuo: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-license-check |
… check (#5053) ### Summary `pull-license-check` on tiflash was failing because the OCI-downloaded `license-eye` binary is glibc-dynamically-linked while the `utils` image (oras/yq provider) has no glibc (`cannot execute: required file not found`). Instead of the initContainer + shared-volume glibc workaround, switch to the official **`apache/skywalking-eyes:0.4.0`** image: it ships its own (musl) runtime and has `license-eye` as its entrypoint, so the job is a single container: ```yaml containers: - name: main image: apache/skywalking-eyes:0.4.0 args: ["-c", ".github/licenserc.yml", "header", "check"] ``` Verified on the cluster: the image pulls and `license-eye` runs (`--version`). ### Related Tested against pingcap/tiflash#11061.
|
/test pull-license-check |
2 similar comments
|
/test pull-license-check |
|
/test pull-license-check |
…check (#5056) ### Summary STEP 2 of consolidating the tiflash license check into the standalone presubmit: - Remove the `License check` stage (and the now-unused `OCI_ARTIFACT_HOST` env in `merged_build`) from `merged_build` / `pull_integration_test` pipelines across all tiflash branches (12 files) - Make `pull-license-check` **required** (`optional: false`) in `prow-jobs/pingcap/tiflash/common-presubmits.yaml` The in-pipeline license steps were also broken anyway: the OCI-downloaded `license-eye` is glibc-linked while the `utils` image is glibc-less. ### Verified - All changed Jenkins pipelines pass `.ci/verify-jenkins-pipelines.sh` (Jenkins lint) - `pull-license-check` presubmit validated on pingcap/tiflash#11061 (pass)
What problem does this PR solve?
Issue Number: N/A (draft documentation/compliance artifact)
The root
NOTICEwas last updated in 2022 and no longer represented thecurrent C/C++ source inputs. It also used a different name from the
ThirdPartyNotices.txtconvention used by the other notice updates.What is changed and how it works?
Replaces root
NOTICEwith a self-contained rootThirdPartyNotices.txt.public third-party
contrib/submodules.upstream-NOTICE texts, including the AWS CRT components, gRPC, BoringSSL's
fiat code, and QPL's ISA-L code.
license evidence.
private submodules, system/toolchain libraries, container images, and package
inputs require release-target-specific notice assembly.
.github/licenserc.ymlfor the replacement filename.Check List
Tests
revision recorded in the notice.
git diff --checkSide effects
Documentation
Release note