deps(dm): update vulnerable dependencies on release-8.5 - #12784
Conversation
|
/run-dm-integration-test |
|
/run-dm-compatibility-test |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## release-8.5 #12784 +/- ##
================================================
Coverage ? 53.6668%
================================================
Files ? 1007
Lines ? 138512
Branches ? 0
================================================
Hits ? 74335
Misses ? 58636
Partials ? 5541 🚀 New features to boost your workflow:
|
|
/run-dm-integration-test |
|
/run-dm-compatibility-test |
|
/retest |
|
@joechenrh: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, joechenrh, lidezhu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #12637
release-8.5already includes Go 1.25.12 and the dependency updates from #12773 and #12776, but two actionable dependency findings remain in the current DM image scan:github.com/getkin/kin-openapiv0.131.0 and are fixed in v0.144.0.What is changed and how it works?
go.opentelemetry.io/otelgo.opentelemetry.io/otel/metricgo.opentelemetry.io/otel/sdkgo.opentelemetry.io/otel/sdk/metricgo.opentelemetry.io/otel/tracegithub.com/getkin/kin-openapifrom v0.131.0 to v0.144.0 and accept only the transitive module changes required by that release.This intentionally does not cherry-pick #12769 or #12772: all of their other relevant fixed-version floors are already present on release-8.5, and copying either module graph wholesale would create unrelated release-branch churn.
Check List
Tests
env -u HTTP_PROXY -u HTTPS_PROXY -u ALL_PROXY -u NO_PROXY make dm_unit_test(pass; full race/failpoint suite, includingdm/worker)go test ./dm/openapi ./engine/jobmaster/dm/openapi(pass)go mod tidy -diff(clean)go mod verify(pass)make dm(pass)make cdc engine sync-diff-inspector(pass)go version -mon DM binaries: Go 1.25.12, kin-openapi v0.144.0, gRPC v1.82.1, and the coordinated OpenTelemetry modules at v1.44.0govulncheck ./dm/...: GO-2026-5158 and the two kin-openapi advisories are no longer reportedThe vulnerability scan still reports existing findings outside this focused update: a coordinated etcd upgrade, Avro advisories with no published fixed release, and a TiDB pseudo-version mapping false positive whose selected release-8.5 commit already contains the upstream fix. This PR does not claim that all
govulncheckfindings are cleared.Questions
Will it cause performance regression or break compatibility?
No expected regression. These are fixed-version dependency updates; the directly affected OpenAPI packages, the full DM race/failpoint suite, and all shipped binaries build successfully.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note