Skip to content

docs: add Go third-party notices - #2731

Open
dillon-zheng wants to merge 1 commit into
pingcap:masterfrom
dillon-zheng:add-third-party-notices
Open

docs: add Go third-party notices#2731
dillon-zheng wants to merge 1 commit into
pingcap:masterfrom
dillon-zheng:add-third-party-notices

Conversation

@dillon-zheng

@dillon-zheng dillon-zheng commented Aug 26, 2026

Copy link
Copy Markdown

What problem does this PR solve?

Issue Number: ref #2736

What is changed and how it works?

Adds a self-contained root ThirdPartyNotices.txt for the Go dependency graph.

  • Scope: Linux/amd64 go list -deps ./..., with tests excluded.
  • Excludes the Go standard library and first-party github.com/pingcap/ and github.com/tikv/ modules.
  • Source commit: 9f6ebb7edc26ca0ba53b9f4a70de22388f865910.
  • Generator: us-docker.pkg.dev/pingcap-testing-account/internal/test/notice-generator@sha256:60fd803ae1ff5d74cc158cc9190d27c2b0bef4b892bcbe8d9b7de0c1ae2252d5 (Go 1.25.12, go-licenses v1.6.0).
  • The strict collector check passed. The renderer preserves the BSD-3-Clause evidence in Prometheus's vendored goautoneg README when go-licenses save omits it.

Check List

Tests

  • No code
    • Ran the strict Go-license collector check for Linux/amd64 ./....
    • Verified 108 components and a self-contained rendered notice with no generator-local paths or raw collector URLs.

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Signed-off-by: weizheng <wei.zheng@pingcap.com>
@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
ti-chi-bot Bot requested a review from srstack August 26, 2026 07:25
@ti-chi-bot ti-chi-bot Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 26, 2026
@pingcap-cla-assistant

pingcap-cla-assistant Bot commented Aug 26, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (1)
  • ThirdPartyNotices.txt
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: dbd138f0-2814-47bb-9388-57c6d74dceeb

📥 Commits

Reviewing files that changed from the base of the PR and between 9f6ebb7 and 60dcf67.

📒 Files selected for processing (1)
  • ThirdPartyNotices.txt

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

codecov-commenter commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.34%. Comparing base (9f6ebb7) to head (60dcf67).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2731      +/-   ##
==========================================
- Coverage   42.43%   42.34%   -0.09%     
==========================================
  Files         426      426              
  Lines       47364    47364              
==========================================
- Hits        20096    20052      -44     
- Misses      24570    24613      +43     
- Partials     2698     2699       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dillon-zheng

Copy link
Copy Markdown
Author

/type development

@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@dillon-zheng: The label(s) type/development cannot be applied, because the repository doesn't have them.

Details

In response to this:

/type development

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@dillon-zheng

Copy link
Copy Markdown
Author

/type enhancement

@ti-chi-bot ti-chi-bot Bot added the type/enhancement Categorizes issue or PR as related to an enhancement. label Sep 4, 2026
@dillon-zheng
dillon-zheng marked this pull request as ready for review September 4, 2026 07:37
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2026
@ti-chi-bot
ti-chi-bot Bot requested a review from kaaaaaaang September 4, 2026 07:37
@dillon-zheng

Copy link
Copy Markdown
Author

/remove-type enhancement

@ti-chi-bot ti-chi-bot Bot removed the type/enhancement Categorizes issue or PR as related to an enhancement. label Sep 4, 2026
@dillon-zheng

Copy link
Copy Markdown
Author

/retest

@bb7133 bb7133 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot Bot added the lgtm label Sep 4, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

[LGTM Timeline notifier]

Timeline:

  • 2026-09-04 08:00:54.440460109 +0000 UTC m=+1439089.611554226: ☑️ agreed by bb7133.

@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@nolouch: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants