Skip to content

Revert an unexpected commit#714

Merged
lilin90 merged 3 commits into
pingcap:masterfrom
lilin90:home-card-fix
Jun 12, 2026
Merged

Revert an unexpected commit#714
lilin90 merged 3 commits into
pingcap:masterfrom
lilin90:home-card-fix

Conversation

@lilin90

@lilin90 lilin90 commented Jun 12, 2026

Copy link
Copy Markdown
Member

Revert commit bcab1e1

lilin90 added 2 commits June 12, 2026 18:09
Tweak styles in DocHome: update heading color and weight, add bottom padding, and switch to website color tokens. Adjust TOC link sizing and vertical padding (14px→13px, 0.25rem→4px) and change hover behavior to set color and a left border instead of bolding text. These changes improve contrast and provide a clearer hover indicator for table-of-contents entries.
@vercel

vercel Bot commented Jun 12, 2026

Copy link
Copy Markdown

@lilin90 is attempting to deploy a commit to the test-vi Team on Vercel.

A member of the Team first needs to authorize it.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors and simplifies the layout and styling of the DocHome component, including updating text styles, transitioning the card container to use an auto-fit grid layout, and removing the redundant colspan prop in favor of colSpan. However, simplifying the gridColumn to a fixed span can cause horizontal layout overflow on smaller screens. It is recommended to responsively cap the grid column span based on the breakpoint.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/components/MDXComponents/DocHome.tsx
@lilin90 lilin90 changed the title Fix doc home cards display issue Revert an unexpected commit Jun 12, 2026
@lilin90
lilin90 marked this pull request as ready for review June 12, 2026 10:51
@lilin90
lilin90 merged commit 41ab977 into pingcap:master Jun 12, 2026
1 check failed
@lilin90
lilin90 deleted the home-card-fix branch June 12, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants