Skip to content

style(web): fix inconsistencies in new settings layouts - #10177

Open
extoci wants to merge 3 commits into
pingdotgg:mainfrom
extoci:t3code/fix-settings-ui-consistency
Open

style(web): fix inconsistencies in new settings layouts#10177
extoci wants to merge 3 commits into
pingdotgg:mainfrom
extoci:t3code/fix-settings-ui-consistency

Conversation

@extoci

@extoci extoci commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix inconsistencies in settings:

(human written note: for some of the images in "before" i used max contrast to make it more visible, my agent did not when capturing after screenshots, this is not a regression)

Screenshots

Before (weird unnecessary left padding on Start form Origin):

before-01-projects-and-threads

After:

after-01-projects-and-threads

Before (rounded borders on non-edge items in Source Control & Remote Environments):

before-02-source-control-providers before-03-version-control before-04-remote-environments

After:

after-02-source-control-providers after-03-version-control after-04-remote-environments

Codex, GPT-6 via T3 Code, on behalf of Exotic.

Note

Remove rounded corners and responsive padding from settings row layouts

  • Removes rounded-corner utilities from endpoint rows, discovery item rows, source-control skeleton rows, and the shared ITEM_ROW_CLASSNAME in itemRows.ts
  • Removes responsive left-padding from the start-from-origin setting row in GeneralSettingsPanel within SettingsPanels.tsx
  • Updates ITEM_ROW_CLASSNAME documentation to describe parent-owned borders and separators
  • Risk: settings rows now render with square corners; visual regression possible in any out-of-tree consumers of ITEM_ROW_CLASSNAME or ENDPOINT_ROW_CLASSNAME

Macroscope summarized 8d93ec0.

Fix the extra project-row indent and rounded internal separators in grouped settings sections. Let the parent sections own row geometry across source control and connections.

Codex, GPT-5.6-luna via T3 Code.
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 5, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 5, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 8d93ec0

Macroscope's review found this PR approvable — This is a small, localized settings-layout cleanup that changes only row spacing, indentation, corner rounding, and hover presentation across existing settings and onboarding lists. It introduces no new behavior, data changes, controls, or product-default changes.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@macroscopeapp
macroscopeapp Bot dismissed their stale review September 5, 2026 19:38

Dismissing prior approval to re-evaluate 2e683d8

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 5, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review September 5, 2026 19:48

Dismissing prior approval to re-evaluate 8d93ec0

@extoci

extoci commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

note: i reverted this last change because i think codex just messed up lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant