fix(mobile): stop clipping expanded tool groups - #10212
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a contained mobile UI bug fix that replaces the problematic masked group rendering with a clipped list and localized edge fades, while synchronizing expanded-group sizing with LegendList measurements. Its effects are limited to existing expanded tool groups and do not introduce new capabilities, schema changes, product-default changes, or static-analysis overrides. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
Opening a row's details inside a tool group left an unpainted band the size of the growth: the group's MaskedView hosts the list inside a SwiftUI mask whose native bounds kept the old height, so everything past it was clipped even though layout and accessibility frames were right. Draw the scroll-edge fades as screen-colored gradients over a plain clipped view instead, and read the group's content size from LegendList's layout so the outer row resizes in the same commit. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
5e25d25 to
65b1b9c
Compare
Stacked on #10211.
Problem
Opening a row's details inside an expanded tool group left an unpainted band the size of the growth (88 points for a five-line command output). Layout was correct everywhere — LegendList's sizes, the outer row's measured height, and accessibility frames all matched — but the pixels for everything past the group's old bottom edge were missing until the group was collapsed and reopened.
The group's scroll-edge fades come from
@expo/ui'sMaskedView, which hosts the list inside a SwiftUI.maskviaRNHostView. That host keeps the bounds it had when the mask was built, so a resize clips the tail. #9359 worked around the first symptom by forcing the list's height; this is the second.Confirmed by elimination on the simulator: removing layout animations, the inner
ScrollView,selectable,absoluteFill, andmaintainVisibleContentPositioneach left the band in place; swappingMaskedViewfor a plain clippedViewremoved it.Fix
overflow: hiddenview and draw the fades as two screen-colored SVG gradients over the edges, each fading in only while content continues past that edge (same scroll-offset math, inverted from "cover" to "fade"). The screen color comes fromThreadFeed, which already reads the theme.totalSizesignal instead of the nativeonContentSizeChange, so the outer row resizes in the same commit as the row measurement that changed it.ShimmeringWorkContentstill usesMaskedView; its mask never resizes.Verification
tsc --noEmitforapps/mobile, targeted lint and format.mainand this branch. The blank band after expanding theffmpegrow: 88 points → 0. Fades verified on a 12-call group: bottom fade present at offset 0, top fade present when scrolled to the end, both painted in the screen color.Recording of the expand/collapse, before on the left:
https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/f0dfbe332a6d42b8/stack-pair-expand.mp4
Implemented by Claude Fable 5 in the Claude Code harness.
Note
Fix clipped expanded tool groups and settle workflow coordinator members in thread activity
MaskedViewcomposite mask inThreadWorkGroupListwith a clipped container and separate animatedEdgeFadeoverlays that fade only at edges with remaining content, using the current screen theme colorThreadFeedandThreadWorkLogso edge fades match the backgroundisAgentInternalActivityto retain task lifecycle rows with a task identifier and agent kind for batch processing instead of filtering them as internalagentSpawnRow, a terminal workflow coordinator now settles members that lack their own end event or remain in progress; explicitly reported member statuses are preservedtoDerivedWorkLogEntrywhen no other lifecycle status is presentThreadWorkGroupListnow uses a ref callback subscribing to LegendList total-size updates instead of the native content-size callback; verify scroll fade visibility and content-height bookkeeping remain correct under rapid resize and theme switchesMacroscope summarized 65b1b9c.