refactor(web): remove unused overlay components and exports - #10222
refactor(web): remove unused overlay components and exports#10222juliusmarminge wants to merge 1 commit into
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This PR removes unused internal overlay wrappers, aliases, and exports while leaving the active dialog, alert-dialog, sheet, popover, and tooltip behavior intact. Repository usage checks show no current consumers of the removed symbols, and the web package is private. You can add or adjust custom eligibility rules. Learn more. |
|
Closing this layer after maintainer review. Core UI component modules are kept as complete pasted component sets, so this partial subcomponent cleanup is intentionally dropped. #10228 now records the matching Knip export exception while retaining whole-file detection. |
The overlay modules export unused handles, aliases, and wrapper components. Remove those declarations and keep helpers private when their own module still uses them.
The active dialog, alert-dialog, sheet, popover, and tooltip implementations stay intact.
Layer 1 of 7 in the web runtime-export cleanup stack.
Verification at the integrated stack tip:
vp run --filter @t3tools/web testpasses all 4,052 tests across 333 files. Web typecheck and changed-file lint/format pass. The stack passesvp run knip:check, including repository file/dependency checks and runtime-export checks for web and all seven internal packages.Model: gpt-6 astra. Harness: Codex in T3 Code.
Note
Remove unused exports and wrappers from
alert-dialogoverlay componentsalert-dialogmodule by removing theAlertDialogCreateHandlefactory alias and theAlertDialogTriggerwrapper that added a data attribute before delegating to the primitive trigger.AlertDialogPortal,AlertDialogBackdrop,AlertDialogOverlay,AlertDialogContent, andAlertDialogViewportfrom alert-dialog.tsx.AlertDialogPopupand remaining dialog components stay exported.AlertDialogCreateHandle,AlertDialogPortal,AlertDialogBackdrop,AlertDialogOverlay,AlertDialogTrigger,AlertDialogContent,AlertDialogViewport) will no longer resolve from this module.Macroscope summarized 7503d74.