feat(markdown): show the GitHub mark for github.com links - #10324
Conversation
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a localized Markdown UI enhancement: GitHub links use a bundled, theme-tinted mark and no longer fetch a favicon, while other links retain their existing behavior. The native attachment changes and tests stay within the existing Markdown rendering path, with no schema, deployment, security, or static-analysis impact. Notes:
You can add or adjust custom eligibility rules. Learn more. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
Co-Authored-By: Claude Code <noreply@anthropic.com>
Dismissing prior approval to re-evaluate a37d1c1
Every external link in assistant markdown gets the same generic
◉ring, so a paragraph full of PR references reads as noise. GitHub links are by far the most common kind an agent emits, and the ring gives no hint which of them are GitHub.Links whose host is
github.comorgist.github.com(subdomains included) now show the GitHub mark instead. The mark follows the link color, so it stays correct across themes and in both light and dark mode. Other hosts keep the ring.ChatMarkdownswaps the ring for the existingGitHubIcon,currentColor.t3-link:attachment carries a tint flag through the shadow node, and the Obj-C side tints the PNG with the run's foreground color. The attachment string keepsNSForegroundColorAttributeName, so the async icon-load re-apply tints with the link color instead of falling back tolabelColor.<Image tintColor>inline with the link text.markdownLinks.tsand is unit-tested (www.github.com,gist.github.com,github.com.evil.comrejected, non-http schemes ignored).Before / after
Same seeded thread, iPhone 17 Pro sim, iOS 26.5. Left is
main, right is this branch.Light
Dark
Verification
apps/mobile/src/lib/markdownLinks.test.ts(49 tests), mobiletsc, webtsgo, lint, format.Model: Claude Fable 5. Harness: Claude Code in T3 Code.
Note
Render GitHub mark for github.com links in markdown
MarkdownLinkFaviconskips favicon fetching for GitHub hosts; iOST3MarkdownTextAttachmentRangegains a tint flag consumed byT3MarkdownTextApplyAttachmentsMacroscope summarized a37d1c1.