fix(client-runtime): typecheck device hub ticket request on main - #11304
Conversation
#10677 and #11029 merged in succession without a textual conflict, but #11029 changed executeAuthenticatedEnvironmentHttpRequest to require a group and hand back a group-scoped client, while #10677's new deviceHubAccess.ts still called the full-API client. Pass the auth group and call webSocketTicket on the group client. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This small fix selects the correct auth-group client for the existing device-hub websocket-ticket request, while leaving cookie-session behavior unchanged. Because the modified path handles authentication credentials and ticket issuance, it warrants focused human review despite its limited scope. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe authenticated WebSocket ticket request now uses ChangesWebSocket ticket request
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The WebSocket ticket request uses the correct scoped API and auth group, with no remaining merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
## What's Changed * fix(mobile): prevent Hermes crashes when opening threads by @jakeleventhal in pingdotgg/t3code#11233 * feat(web): open Usage on the Limits tab by default by @juliusmarminge in pingdotgg/t3code#11261 * perf(web): avoid scanning chat history for sidebar backgrounds by @juliusmarminge in pingdotgg/t3code#11206 * perf(mobile): reuse completed code lines while streaming by @juliusmarminge in pingdotgg/t3code#11211 * perf(client): reduce remote request and message sync overhead by @Bil0000 in pingdotgg/t3code#11029 * fix(web): refresh usage limit countdowns without switching tabs by @t3-code[bot] in pingdotgg/t3code#11187 * fix(client-runtime): typecheck device hub ticket request on main by @juliusmarminge in pingdotgg/t3code#11304 * feat(settings): add per-project overrides for scopable server settings by @juliusmarminge in pingdotgg/t3code#11176 * feat(web): pick settings environment and project as two selects by @juliusmarminge in pingdotgg/t3code#10636 * feat(settings): edit any scopable setting as a project override by @juliusmarminge in pingdotgg/t3code#10639 * feat(web): float device streams over chat by @juliusmarminge in pingdotgg/t3code#11285 * fix(web): floating preview can use the margins beside the composer by @juliusmarminge in pingdotgg/t3code#11290 * perf(client-runtime): speed up message sync on desktop and mobile by @Bil0000 in pingdotgg/t3code#11302 * fix(web): use the configured panel shortcut on the PR page by @Bil0000 in pingdotgg/t3code#11292 * feat(web): add PR page selections to new draft threads by @Bil0000 in pingdotgg/t3code#11296 **Full Changelog**: pingdotgg/t3code@v0.0.41-nightly.20260911.1551...v0.0.41-nightly.20260911.1564 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.41-nightly.20260911.1564
Main's Check job fails typecheck in `packages/client-runtime` (run). #10677 and #11029 merged back-to-back with no textual conflict, but #11029 changed `executeAuthenticatedEnvironmentHttpRequest` to require a `group` and hand the callback a group-scoped client, while #10677's new `deviceHubAccess.ts` still called the full-API client (`client.auth.webSocketTicket`).
Pass `group: "auth"` and call `client.webSocketTicket` on the group client, matching the other callers. Typecheck for client-runtime, web, and mobile passes locally.
Claude Fable 5 via Claude Code in T3 Code.
🤖 Generated with Claude Code
Summary by CodeRabbit