fix(web): update add-project toggle label in cancel state#1248
Merged
juliusmarminge merged 3 commits intopingdotgg:mainfrom Mar 20, 2026
Merged
Conversation
- Update the sidebar button aria-label to reflect add/cancel states - Improves accessibility when toggling project path entry
- Show "Cancel add project" while project path entry is open - Keep the tooltip label aligned with the add-project toggle state
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
vouch:unvouched
juliusmarminge
approved these changes
Mar 20, 2026
aaditagrawal
pushed a commit
to aaditagrawal/t3code
that referenced
this pull request
Mar 21, 2026
7 tasks
gabrielMalonso
pushed a commit
to gabrielMalonso/t3code
that referenced
this pull request
Mar 21, 2026
bulbulogludemir
added a commit
to bulbulogludemir/krabbycode
that referenced
this pull request
Mar 21, 2026
Ported from pingdotgg/t3code (bc12421..9e29c9d): - feat: persist modelOptions, refactor provider-specific logic (pingdotgg#1121) Sticky model/options in composer, composerProviderRegistry, shared resolveSelectableModel utility - fix(ChatView): update scroll button styles (pingdotgg#1246) - fix(web): show health banner for selected provider (pingdotgg#1223) - fix(web): update add-project toggle label in cancel state (pingdotgg#1248) - Prefer Claude user ID for telemetry identity (pingdotgg#1249) - feat: configurable base directory (pingdotgg#826) Renamed stateDir → baseDir, T3CODE_STATE_DIR → T3CODE_HOME, deriveServerPaths for attachmentsDir/logsDir/dbPath/anonymousIdPath All changes adapted for Krabby branding and merged with existing features. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Updated the sidebar add-project toggle so its text matches the control's cancel state when the add-project form is open.
Specifically:
aria-labelnow switches betweenAdd projectandCancel add projectAdd projectandCancel add projectWhy
The toggle already changes behavior when the add-project form is open, but its text stayed stuck in the add-project state. Aria label and hover tooltip text were left out of sync with the actual action.
This is a small bug fix that makes the control state explicit and consistent.
UI Changes
Before:
Add project, accessible labelAdd projectAdd project, accessible labelAdd projectAfter:
Add project, accessible labelAdd projectCancel add project, accessible labelCancel add projectChecklist
Note
Fix add-project button label and tooltip to show 'Cancel add project' when active
The aria-label and tooltip text for the add-project button in the Sidebar were always showing 'Add project', even when the project path entry was open. Both now conditionally render 'Cancel add project' or 'Add project' based on the
shouldShowProjectPathEntrystate.Macroscope summarized f43a3ff.