Skip to content

Prefer Claude user ID for telemetry identity#1249

Merged
juliusmarminge merged 1 commit intomainfrom
feature/telemetry-claude-user-id
Mar 20, 2026
Merged

Prefer Claude user ID for telemetry identity#1249
juliusmarminge merged 1 commit intomainfrom
feature/telemetry-claude-user-id

Conversation

@juliusmarminge
Copy link
Member

@juliusmarminge juliusmarminge commented Mar 20, 2026

  • Read ~/.claude.json when Codex account ID is unavailable
  • Fall back to the existing anonymous telemetry ID

What Changed

Why

UI Changes

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Prefer Claude user ID from ~/.claude.json for telemetry identity

Updates getTelemetryIdentifier in Identify.ts to check ~/.claude.json for a userID field after the Codex account ID but before falling back to the anonymous ID. A new getClaudeUserId effect reads and decodes the file using ClaudeJsonSchema, and the resulting ID is hashed like other identifiers. Risk: adds a file read and JSON decode on every telemetry identifier resolution.

Macroscope summarized 98c8c03.

- Read `~/.claude.json` when Codex account ID is unavailable
- Fall back to the existing anonymous telemetry ID
@coderabbitai
Copy link

coderabbitai bot commented Mar 20, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 760d4139-65b3-476c-9c4a-536ffbe7dec3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/telemetry-claude-user-id

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Mar 20, 2026
@juliusmarminge juliusmarminge merged commit ef25691 into main Mar 20, 2026
10 checks passed
@juliusmarminge juliusmarminge deleted the feature/telemetry-claude-user-id branch March 20, 2026 18:43
aaditagrawal pushed a commit to aaditagrawal/t3code that referenced this pull request Mar 21, 2026
gabrielMalonso pushed a commit to gabrielMalonso/t3code that referenced this pull request Mar 21, 2026
bulbulogludemir added a commit to bulbulogludemir/krabbycode that referenced this pull request Mar 21, 2026
Ported from pingdotgg/t3code (bc12421..9e29c9d):

- feat: persist modelOptions, refactor provider-specific logic (pingdotgg#1121)
  Sticky model/options in composer, composerProviderRegistry, shared
  resolveSelectableModel utility
- fix(ChatView): update scroll button styles (pingdotgg#1246)
- fix(web): show health banner for selected provider (pingdotgg#1223)
- fix(web): update add-project toggle label in cancel state (pingdotgg#1248)
- Prefer Claude user ID for telemetry identity (pingdotgg#1249)
- feat: configurable base directory (pingdotgg#826)
  Renamed stateDir → baseDir, T3CODE_STATE_DIR → T3CODE_HOME,
  deriveServerPaths for attachmentsDir/logsDir/dbPath/anonymousIdPath

All changes adapted for Krabby branding and merged with existing features.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant