fix: add svelte-specific favicon candidates to the resolver#1613
fix: add svelte-specific favicon candidates to the resolver#1613nevthereal wants to merge 3 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
|
Closing as part of backlog cleanup: this PR is stale, currently conflicting with main, has no approval, and has not had active remediation for 30+ days. If the change is still relevant, please rebase onto current main and request reopening or submit a focused current diff. Thank you for the contribution. |
|
@juliusmarminge I'd be down to take this on with a fresh base if there's no response for a few days, having Svelte(Kit) favicons would be great. |

pretty "important" for svelte devs since we'd also like to see our favicons in the sidebar
Note
Low Risk
Scoped path-resolution changes and added tests; minimal risk aside from potentially changing which local icon file is selected when multiple candidates exist.
Overview
Improves the project favicon resolver to detect SvelteKit-style icons by scanning
src/app.html/app.html, supporting%sveltekit.assets%hrefs, and includingstatic/as a candidate asset root (in addition topublic/).Updates resolution logic to ignore remote/data URLs and to try relative-to-source and project-root candidates, and adds tests covering SvelteKit
static/icon serving through/api/project-favicon.Written by Cursor Bugbot for commit f87a54a. This will update automatically on new commits. Configure here.
Note
Add
/staticfavicon candidates andsrc/app.htmlscanning toProjectFaviconResolverstatic/favicon.*,static/icon.*, andstatic/logo.*to theFAVICON_CANDIDATESsearch list in ProjectFaviconResolver.ts.src/app.htmlandapp.htmltoICON_SOURCE_FILESso<link rel="icon">declarations in SvelteKit app shells are scanned.resolveIconHrefto strip the%sveltekit.assets%prefix, resolve hrefs relative to their source file, and skip external ordata:URIs.Macroscope summarized f87a54a.