Skip to content

fix: add svelte-specific favicon candidates to the resolver#1613

Closed
nevthereal wants to merge 3 commits into
pingdotgg:mainfrom
nevthereal:main
Closed

fix: add svelte-specific favicon candidates to the resolver#1613
nevthereal wants to merge 3 commits into
pingdotgg:mainfrom
nevthereal:main

Conversation

@nevthereal

@nevthereal nevthereal commented Mar 31, 2026

Copy link
Copy Markdown

pretty "important" for svelte devs since we'd also like to see our favicons in the sidebar


Note

Low Risk
Scoped path-resolution changes and added tests; minimal risk aside from potentially changing which local icon file is selected when multiple candidates exist.

Overview
Improves the project favicon resolver to detect SvelteKit-style icons by scanning src/app.html/app.html, supporting %sveltekit.assets% hrefs, and including static/ as a candidate asset root (in addition to public/).

Updates resolution logic to ignore remote/data URLs and to try relative-to-source and project-root candidates, and adds tests covering SvelteKit static/ icon serving through /api/project-favicon.

Written by Cursor Bugbot for commit f87a54a. This will update automatically on new commits. Configure here.

Note

Add /static favicon candidates and src/app.html scanning to ProjectFaviconResolver

  • Appends static/favicon.*, static/icon.*, and static/logo.* to the FAVICON_CANDIDATES search list in ProjectFaviconResolver.ts.
  • Adds src/app.html and app.html to ICON_SOURCE_FILES so <link rel="icon"> declarations in SvelteKit app shells are scanned.
  • Updates resolveIconHref to strip the %sveltekit.assets% prefix, resolve hrefs relative to their source file, and skip external or data: URIs.

Macroscope summarized f87a54a.

@coderabbitai

coderabbitai Bot commented Mar 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: fd924a11-e414-4876-93be-bdc20398195e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Mar 31, 2026
@nevthereal nevthereal changed the title fix: add missing static favicon candidates to the resolver fix: add missing "/static" favicon candidates to the resolver Mar 31, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment thread apps/server/src/project/Layers/ProjectFaviconResolver.ts
@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Apr 1, 2026
@nevthereal nevthereal changed the title fix: add missing "/static" favicon candidates to the resolver fix: add svelte-specific favicon candidates to the resolver Apr 1, 2026
@juliusmarminge

Copy link
Copy Markdown
Member

Closing as part of backlog cleanup: this PR is stale, currently conflicting with main, has no approval, and has not had active remediation for 30+ days. If the change is still relevant, please rebase onto current main and request reopening or submit a focused current diff. Thank you for the contribution.

@VitroidFPV

Copy link
Copy Markdown

@juliusmarminge I'd be down to take this on with a fresh base if there's no response for a few days, having Svelte(Kit) favicons would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants