fix(release): bump electron-builder so pnpm 11 deduped deps land in the asar#3790
Conversation
electron-builder 26.8.1's pnpm module collector predates pnpm >= 10.29.3's deduped dependency reporting (pnpm/pnpm#10601), so after the pnpm 11 bump in pingdotgg#3772 every deduped transitive prod dep was silently dropped from app.asar - 38 packages missing, and the desktop app crashes at launch on the first one (fast-check). The collector fix shipped in electron-builder 26.9.0 (electron-userland/electron-builder#9618); pin the current 26.x. Fixes pingdotgg#3789
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Single dependency version bump for electron-builder build tool. The only source change is the version number in package.json; all other changes are mechanical lockfile updates. No runtime application code is affected. You can customize Macroscope's approvability policy. Learn more. |
Fixes #3789
What Changed
electron-builder 26.8.1 -> 26.15.6 in apps/desktop devDependencies, plus lockfile.
Why
#3772 bumped pnpm 10.24 -> 11.10. pnpm >= 10.29.3 reports deduped deps
differently (pnpm/pnpm#10601), and 26.8.1's pnpm module collector predates the
fix for that (shipped in 26.9.0, electron-userland/electron-builder#9618), so
deduped transitive prod deps get silently dropped from app.asar. Current
nightly crashes at launch on the first missing import (fast-check).
Verified: built mac arm64
--target diron master vs this branch, diffed theasar. Master: 44 prod deps missing. This branch: all present, app launches.
Checklist
Note
Bump
electron-builderto 26.15.6 so pnpm 11 deduped dependencies land in the asarUpdates
electron-builderin apps/desktop/package.json from 26.8.1 to 26.15.6. The older version did not correctly include pnpm 11 deduplicated dependencies in the asar archive, causing missing modules at runtime.Macroscope summarized 2343cfc.