Skip to content

fix(release): bump electron-builder so pnpm 11 deduped deps land in the asar#3790

Merged
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
avocardow:fix/desktop-asar-missing-transitive-deps
Jul 8, 2026
Merged

fix(release): bump electron-builder so pnpm 11 deduped deps land in the asar#3790
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
avocardow:fix/desktop-asar-missing-transitive-deps

Conversation

@avocardow

@avocardow avocardow commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Fixes #3789

What Changed

electron-builder 26.8.1 -> 26.15.6 in apps/desktop devDependencies, plus lockfile.

Why

#3772 bumped pnpm 10.24 -> 11.10. pnpm >= 10.29.3 reports deduped deps
differently (pnpm/pnpm#10601), and 26.8.1's pnpm module collector predates the
fix for that (shipped in 26.9.0, electron-userland/electron-builder#9618), so
deduped transitive prod deps get silently dropped from app.asar. Current
nightly crashes at launch on the first missing import (fast-check).

Verified: built mac arm64 --target dir on master vs this branch, diffed the
asar. Master: 44 prod deps missing. This branch: all present, app launches.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Bump electron-builder to 26.15.6 so pnpm 11 deduped dependencies land in the asar

Updates electron-builder in apps/desktop/package.json from 26.8.1 to 26.15.6. The older version did not correctly include pnpm 11 deduplicated dependencies in the asar archive, causing missing modules at runtime.

Macroscope summarized 2343cfc.

electron-builder 26.8.1's pnpm module collector predates pnpm >= 10.29.3's
deduped dependency reporting (pnpm/pnpm#10601), so after the pnpm 11 bump
in pingdotgg#3772 every deduped transitive prod dep was silently dropped from
app.asar - 38 packages missing, and the desktop app crashes at launch on
the first one (fast-check). The collector fix shipped in electron-builder
26.9.0 (electron-userland/electron-builder#9618); pin the current 26.x.

Fixes pingdotgg#3789
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ec99181c-3afd-42fd-b500-b16582f4dd13

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Jul 8, 2026
@macroscopeapp

macroscopeapp Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Single dependency version bump for electron-builder build tool. The only source change is the version number in package.json; all other changes are mechanical lockfile updates. No runtime application code is affected.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Nightly won't launch: Cannot find package 'fast-check' (app.asar missing ~40 transitive deps)

2 participants