Expose mobile PR indicator labels to accessibility by juliusmarminge · Pull Request #3828 · pingdotgg/t3code

juliusmarminge · 2026-07-09T13:37:01Z

Summary

Marks the mobile thread row PR indicator as an accessible text element.
Uses the existing provider-aware PR accessibility label for screen readers.

Testing

Not run (PR content generated from provided commit and diff metadata).

Note

Low Risk
UI and accessibility-only changes in mobile thread list presentation with updated unit tests; no auth, data, or API impact.

Overview
Thread list rows now announce pull request context to screen readers by setting the row accessibilityLabel to thread title plus the existing provider-aware PR label (e.g. #3774 pull request merged), instead of only the title.

Visual tweaks: the branch SymbolView is removed from the subtitle row, and the on-screen PR number drops the # prefix (3774 vs #3774) while accessibilityLabel still includes # and GitLab merge-request wording. Unused muted-color styling tied to the branch icon is cleaned up, and the PR subtitle container no longer carries its own accessibilityLabel.

^{Reviewed by Cursor Bugbot for commit d0d1129. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Expose PR indicator labels to accessibility in mobile thread list rows

The ThreadListRow accessible name now includes PR info (title + pr.accessibilityLabel) when a PR is present, instead of just the thread title.
The branch SymbolView icon preceding the subtitle text is removed from the thread list row.
presentThreadPr label is changed from #${pr.number} to String(pr.number), dropping the leading # from the compact PR label. Tests are updated to match.
Behavioral Change: consumers of ThreadPrPresentation.label (e.g. displayed PR badges) will no longer show a # prefix on the PR number.

^{Macroscope summarized d0d1129.}

- Add shared PR presentation for compact #number labels - Render PR state icons with theme-aware colors Co-authored-by: codex <codex@users.noreply.github.com>

- Add accessible change request labels that say merge request for GitLab - Keep compact thread list labels as PR numbers

coderabbitai · 2026-07-09T13:37:10Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9f00ddf5-8257-4d2c-9f91-3556c8ba4705

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feature/mobile-pr-number-indicator

_{Comment @coderabbitai help to get the list of available commands.}

Co-authored-by: codex <codex@users.noreply.github.com>

macroscopeapp · 2026-07-09T13:43:40Z

Approvability

Verdict: Needs human review

1 blocking correctness issue found. An unresolved review comment flags that the branch indicator icon (arrow.triangle.branch) was removed from thread rows, which may be an unintended user-visible regression. Human review needed to confirm whether this removal was intentional.

^{You can customize Macroscope's approvability policy. Learn more.}

Co-authored-by: codex <codex@users.noreply.github.com>

macroscopeapp · 2026-07-09T13:46:28Z

-              tintColor={compact ? iconSubtleColor : effectiveMuted}
-              type="monochrome"
-            />
            <Text


🟡 Medium threads/thread-list-items.tsx:497

The branch indicator icon (arrow.triangle.branch SymbolView) was removed from the subtitle row, so every thread row that shows branch/environment metadata no longer renders the branch icon. This is a user-visible regression affecting both compact and sidebar thread lists. If removing the icon was intentional, consider documenting the rationale; otherwise, restore the SymbolView before the subtitle text.

Suggested change

<Text

<>

<SymbolView

name="arrow.triangle.branch"

size={10}

tintColor={compact ? iconSubtleColor : undefined}

type="monochrome"

/>

<Text

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:

In file @apps/mobile/src/features/threads/thread-list-items.tsx around line 497: The branch indicator icon (`arrow.triangle.branch` `SymbolView`) was removed from the subtitle row, so every thread row that shows branch/environment metadata no longer renders the branch icon. This is a user-visible regression affecting both compact and sidebar thread lists. If removing the icon was intentional, consider documenting the rationale; otherwise, restore the `SymbolView` before the subtitle text.

… + desktop packaging) Merge upstream/main into the fork. Notable upstream changes: Clerk stack upgrade (pingdotgg#3821), mobile offline persistence + preferences refactor (pingdotgg#3795), mobile PR number badges + a11y (pingdotgg#3827, pingdotgg#3828), font embedding (pingdotgg#3823), worktree metadata preservation during branch sync (pingdotgg#3822), codex reasoning labels (pingdotgg#3824), desktop native optional dependency packaging (pingdotgg#3816). Preserved fork features across conflicts: iOS personal-team build support, Material3 dynamic accent theming, verbose work-log, mobile visible queue, MarkdownCodeBlock, native Android composer/header layout, and the fork's asar:false + afterPack/afterSign node_modules copy hooks for desktop packaging. Lockfile regenerated on pnpm 11 (upstream lock as base).

juliusmarminge and others added 3 commits July 9, 2026 15:11

Show compact PR numbers in mobile thread rows

a401fc6

- Add shared PR presentation for compact #number labels - Render PR state icons with theme-aware colors Co-authored-by: codex <codex@users.noreply.github.com>

Use provider-aware PR labels on mobile

7ecb46e

- Add accessible change request labels that say merge request for GitLab - Keep compact thread list labels as PR numbers

Expose PR number indicator to accessibility

519bb79

github-actions Bot added size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Jul 9, 2026

Merge origin/main into feature/mobile-pr-number-indicator

b4dc215

Co-authored-by: codex <codex@users.noreply.github.com>

github-actions Bot added size:S 10-29 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Jul 9, 2026

juliusmarminge enabled auto-merge (squash) July 9, 2026 13:40

macroscopeapp Bot reviewed Jul 9, 2026

View reviewed changes

Comment thread apps/mobile/src/features/threads/thread-list-items.tsx Outdated

juliusmarminge disabled auto-merge July 9, 2026 13:42

fix(mobile): expose PR details in thread row label

d0d1129

Co-authored-by: codex <codex@users.noreply.github.com>

macroscopeapp Bot reviewed Jul 9, 2026

View reviewed changes

juliusmarminge enabled auto-merge (squash) July 9, 2026 13:47

juliusmarminge merged commit f61fa94 into main Jul 9, 2026
19 of 20 checks passed

juliusmarminge deleted the feature/mobile-pr-number-indicator branch July 9, 2026 14:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Expose mobile PR indicator labels to accessibility#3828

Expose mobile PR indicator labels to accessibility#3828
juliusmarminge merged 5 commits into
mainfrom
feature/mobile-pr-number-indicator

juliusmarminge commented Jul 9, 2026 •

edited by macroscopeapp Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 9, 2026 •

edited

Loading

Review skipped

Uh oh!

Uh oh!

macroscopeapp Bot commented Jul 9, 2026 •

edited

Loading

Uh oh!

macroscopeapp Bot Jul 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

-            <Text
+            <>
+            <SymbolView
+              name="arrow.triangle.branch"
+              size={10}
+              tintColor={compact ? iconSubtleColor : undefined}
+              type="monochrome"
+            />
+            <Text

Uh oh!

Conversation

juliusmarminge commented Jul 9, 2026 • edited by macroscopeapp Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Expose PR indicator labels to accessibility in mobile thread list rows

Uh oh!

coderabbitai Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Uh oh!

macroscopeapp Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

macroscopeapp Bot Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

juliusmarminge commented Jul 9, 2026 •

edited by macroscopeapp Bot

Loading

coderabbitai Bot commented Jul 9, 2026 •

edited

Loading

macroscopeapp Bot commented Jul 9, 2026 •

edited

Loading