Preserve T3 Code identity in macOS development launcher

[juliusmarminge]

Summary

• Keep the native Electron executable inside the branded T3 Code development bundle.
• Preserve macOS bundle identity, Dock labeling, and development runtime behavior.
• Add coverage for launcher path resolution and generated launch scripts.

Testing

• Not run (PR description generated from the provided diff).

---

Note

Low Risk
Dev-only macOS launcher packaging and plist changes; production path still uses the Electron executable with no auth or data impact.

Overview
macOS development now launches through a separate {displayName} Launcher entry in the branded .electron-runtime bundle instead of reusing the Electron binary as the bundle executable.

The launcher shell script execs the in-bundle Contents/MacOS/Electron, not the node_modules copy, so Dock/process identity stays on T3 Code and app.isPackaged stays in dev-like behavior. CFBundleExecutable is patched accordingly (launcher name in dev, Electron otherwise), and LAUNCHER_VERSION is bumped so cached bundles rebuild.

Adds resolveMacLauncherPaths and tests that path resolution and generated scripts target the bundled Electron binary.

^{Reviewed by Cursor Bugbot for commit fe8dc05. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Preserve T3 Code identity in the macOS development launcher bundle

• In development, the macOS app bundle now keeps the native Electron binary at Contents/MacOS/Electron and uses a separate launcher executable as CFBundleExecutable, so the Electron binary is no longer overwritten.
• patchMainBundleInfoPlist now accepts an executableName parameter and writes CFBundleExecutable explicitly to Info.plist.
• A new resolveMacLauncherPaths function centralizes path resolution for the launcher binary, runtime Electron binary, and executable name.
• LAUNCHER_VERSION is bumped from 12 to 14, invalidating cached launcher metadata from previous builds.
• Risk: callers of buildMacLauncher now receive the launcher executable path instead of the Electron binary path.

^{Macroscope summarized fe8dc05.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e6246cff-8b5b-472f-a14e-2694ed84061f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch t3code/012ac0ed

---

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{Bugbot Autofix is ON, but a cloud agent failed to start.}

^{Reviewed by Cursor Bugbot for commit fe8dc05. Configure here.}

[cursor]

Dev launch flips isPackaged true

High Severity

The new launcher execs the native binary inside T3 Code (Dev).app instead of the node_modules Electron.app copy. On macOS, app.isPackaged stays false only when process.execPath ends with Electron.app/Contents/MacOS/Electron, so this makes isPackaged true in development. DesktopEnvironment then resolves appRoot and backendEntryPath from the packaged layout and the local backend fails to start.

Additional Locations (1)

• apps/desktop/scripts/electron-launcher.mjs#L320-L325

 

^{Reviewed by Cursor Bugbot for commit fe8dc05. Configure here.}

[macroscopeapp]

Approvability

Verdict: Needs human review

This PR has an unresolved high-severity review comment identifying a potential bug where the launcher changes could cause app.isPackaged to incorrectly return true in development mode, breaking backend startup. Human review is needed to verify this concern.

^{You can customize Macroscope's approvability policy. Learn more.}