fix(server): clean status fetch temporary packs by nateEc · Pull Request #4338 · pingdotgg/t3code

nateEc · 2026-07-23T08:23:48Z

What Changed

Snapshot temporary pack entries before the status poller starts a remote fetch.
Remove only newly created tmp_pack files when that fetch times out or exits unsuccessfully.
Preserve pre-existing temporary packs and add focused regression coverage.

Why

A status refresh that exceeded the five-second timeout could leave a full temporary pack behind every polling cycle, eventually filling the disk.

Closes #4296

Checklist

Focused test passes: GitVcsDriverCore.test.ts
Server typecheck passes
Targeted lint and formatting pass

Note

Medium Risk
Changes core Git object/ref handling for background status fetches; incorrect promotion or ref updates could corrupt remote-tracking state, though CAS update-ref and ensuring cleanup limit blast radius.

Overview
Replaces the simple background git fetch used for status upstream refresh with an isolated fetch so interrupted or timed-out polls no longer leave large tmp_pack_* files in the shared .git/objects/pack directory (fixes disk growth from repeated 5s timeouts).

Each refresh fetches into a per-operation directory under objects/t3-status-fetch/<uuid> via GIT_OBJECT_DIRECTORY / alternates, fetches only the upstream branch into a temporary ref under refs/t3-status-fetch, then on success promotes packs and loose objects into the real object store and updates the remote-tracking ref with a compare-and-swap update-ref. Temporary refs and directories are always torn down in Effect.ensuring.

Before starting a fetch, legacy tmp_pack_* entries in the shared pack dir older than one hour are removed via exported isStaleGitTemporaryPackFile. The status refresh cache key now includes branchName. Tests cover the stale-pack helper and assert no leftover isolated fetch artifacts after a successful remote status refresh.

^{Reviewed by Cursor Bugbot for commit 46ac662. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix status fetch to use isolated object directories and clean up stale temporary pack files

fetchRemoteForStatus now performs fetches into a per-operation isolated object directory (objects/t3-status-fetch/<uuid>) with a temporary ref, then promotes fetched objects into the main store and atomically updates the remote-tracking ref before cleaning up.
Stale tmp_pack_* files older than 1 hour in the shared pack directory are opportunistically removed before each fetch.
StatusRemoteRefreshCacheKey is expanded to include branchName, so cache entries are now per-branch rather than shared across branches.
Adds isStaleGitTemporaryPackFile utility to identify stale temporary pack files by prefix and mtime.
Risk: The fetch mechanism is substantially rewritten; the atomic ref update uses a 40-zero OID as the expected old value when the ref is absent, and cleanup failures are silently ignored.

^{Macroscope summarized 46ac662.}

- Track temporary pack files that exist before each status refresh. - Remove only new tmp_pack files when the refresh times out or fails. - Add focused regression coverage for preserving pre-existing pack files.

coderabbitai · 2026-07-23T08:23:56Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 30585bf0-f360-438b-b00b-259000575f99

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp · 2026-07-23T08:29:34Z

Approvability

Verdict: Needs human review

This PR rewrites the status fetch mechanism with significant new logic for isolated object directories and cleanup. Multiple unresolved review comments identify potential bugs including orphaned directories (high severity) and incorrect refspec handling (medium severity), warranting human review.

^{You can customize Macroscope's approvability policy. Learn more.}

- Replace operation-scoped pack deletion with a one-hour stale-file grace period. - Run best-effort cleanup before fetches and in an interruption-safe finalizer. - Cover active, stale, completed, and unknown-mtime pack entries.

- Fetch upstream status into a per-operation object store and temporary ref. - Remove failed or timed-out fetch objects immediately without touching concurrent Git work. - Promote complete pack and loose objects before atomically updating the tracking ref. - Verify successful refreshes leave no temporary refs or object directories.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 46ac662. Configure here.}

cursor · 2026-07-23T09:37:02Z

+          fetchedCommit,
+          expectedTarget,
+        ]);
+      }).pipe(Effect.ensuring(cleanupIsolatedFetch));


Orphaned fetch dirs never reaped

High Severity

The new isolated status-fetch mechanism creates temporary directories under objects/t3-status-fetch/. Its cleanup is best-effort (Effect.ignore) and lacks a stale-reaping mechanism for these new directories, unlike the legacy tmp_pack_* files. This can leave behind accumulated directories if cleanup fails, leading to disk space exhaustion.

^{Reviewed by Cursor Bugbot for commit 46ac662. Configure here.}

cursor · 2026-07-23T09:37:02Z

+            "--no-write-fetch-head",
+            "--refmap=",
+            remoteName,
+            `+refs/heads/${branchName}:${temporaryRef}`,


Wrong remote refspec assumed

Medium Severity

The new status fetch builds +refs/heads/${branchName}:… from the remote-tracking shorthand. That assumes a 1:1 refs/heads/* mapping, unlike the previous git fetch <remote> which honored configured refspecs, so custom upstreams (for example pull-request refs) can fail to refresh and leave behindCount stale.

Additional Locations (1)

apps/server/src/vcs/GitVcsDriverCore.ts#L1012-L1014

^{Reviewed by Cursor Bugbot for commit 46ac662. Configure here.}

cursor · 2026-07-23T09:37:02Z

+            "--no-write-fetch-head",
+            "--refmap=",
+            remoteName,
+            `+refs/heads/${branchName}:${temporaryRef}`,


Default-branch tip goes stale

Medium Severity

Status refresh now fetches only refs/heads/${branchName} into a temporary ref, instead of refreshing the whole upstream remote. On a feature branch, aheadOfDefaultCount still compares against local origin/main (via computeAheadCountAgainstBase), so that metric can stay wrong until some other full fetch updates the default remote-tracking tip.

Additional Locations (2)

apps/server/src/vcs/GitVcsDriverCore.ts#L1482-L1488

apps/server/src/vcs/GitVcsDriverCore.ts#L1394-L1416

^{Reviewed by Cursor Bugbot for commit 46ac662. Configure here.}

fix(server): clean status fetch temporary packs

05b134c

- Track temporary pack files that exist before each status refresh. - Remove only new tmp_pack files when the refresh times out or fails. - Add focused regression coverage for preserving pre-existing pack files.

github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jul 23, 2026

macroscopeapp Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread apps/server/src/vcs/GitVcsDriverCore.ts Outdated

cursor Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread apps/server/src/vcs/GitVcsDriverCore.ts Outdated

Comment thread apps/server/src/vcs/GitVcsDriverCore.ts Outdated

fix(server): avoid deleting active Git packs

be38eef

- Replace operation-scoped pack deletion with a one-hour stale-file grace period. - Run best-effort cleanup before fetches and in an interruption-safe finalizer. - Cover active, stale, completed, and unknown-mtime pack entries.

cursor Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread apps/server/src/vcs/GitVcsDriverCore.ts Outdated

github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Jul 23, 2026

cursor Bot reviewed Jul 23, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(server): clean status fetch temporary packs#4338

fix(server): clean status fetch temporary packs#4338
nateEc wants to merge 3 commits into
pingdotgg:mainfrom
nateEc:codex/fix-4296-git-status-pack-leak

nateEc commented Jul 23, 2026 •

edited by macroscopeapp Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 23, 2026 •

edited

Loading

Review skipped

Uh oh!

Uh oh!

Uh oh!

Uh oh!

macroscopeapp Bot commented Jul 23, 2026 •

edited

Loading

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

cursor Bot Jul 23, 2026

Uh oh!

cursor Bot Jul 23, 2026

Uh oh!

cursor Bot Jul 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

nateEc commented Jul 23, 2026 • edited by macroscopeapp Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Changed

Why

Checklist

Fix status fetch to use isolated object directories and clean up stale temporary pack files

Uh oh!

coderabbitai Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Uh oh!

Uh oh!

Uh oh!

macroscopeapp Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Jul 23, 2026

Choose a reason for hiding this comment

Orphaned fetch dirs never reaped

Uh oh!

cursor Bot Jul 23, 2026

Choose a reason for hiding this comment

Wrong remote refspec assumed

Uh oh!

cursor Bot Jul 23, 2026

Choose a reason for hiding this comment

Default-branch tip goes stale

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

nateEc commented Jul 23, 2026 •

edited by macroscopeapp Bot

Loading

coderabbitai Bot commented Jul 23, 2026 •

edited

Loading

macroscopeapp Bot commented Jul 23, 2026 •

edited

Loading